Fix #892 by improving test code (#918)

Author: vgnshiyer

.github/workflows/codecov.yml

@@ -24,19 +24,19 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: ${{ matrix.python-version }}
-#      - name: Install dependencies
-#        run: |
-#          python setup.py install
-#          pip install -U pip
-#          pip install -e ".[async]"
-#          pip install -e ".[adapter]"
-#          pip install -e ".[testing]"
-#          pip install -e ".[adapter_testing]"
-#      - name: Run all tests for codecov
-#        run: |
-#          pytest --cov=./slack_bolt/ --cov-report=xml
-#      - name: Upload coverage to Codecov
-#        uses: codecov/codecov-action@v3
-#        with:
-#          fail_ci_if_error: true
-#          verbose: true
+      - name: Install dependencies
+        run: |
+          python setup.py install
+          pip install -U pip
+          pip install -e ".[async]"
+          pip install -e ".[adapter]"
+          pip install -e ".[testing]"
+          pip install -e ".[adapter_testing]"
+      - name: Run all tests for codecov
+        run: |
+          pytest --cov=./slack_bolt/ --cov-report=xml
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v3
+        with:
+          fail_ci_if_error: true
+          verbose: true

tests/adapter_tests_async/socket_mode/test_async_aiohttp.py

@@ -9,7 +9,7 @@
     setup_mock_web_api_server,
     cleanup_mock_web_api_server,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 from ...adapter_tests.socket_mode.mock_socket_mode_server import (
     start_socket_mode_server,
     stop_socket_mode_server_async,
@@ -29,7 +29,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/adapter_tests_async/socket_mode/test_async_lazy_listeners.py

@@ -9,7 +9,7 @@
     setup_mock_web_api_server,
     cleanup_mock_web_api_server,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 from ...adapter_tests.socket_mode.mock_socket_mode_server import (
     start_socket_mode_server,
     stop_socket_mode_server_async,
@@ -29,7 +29,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/adapter_tests_async/socket_mode/test_async_websockets.py

@@ -9,7 +9,7 @@
     setup_mock_web_api_server,
     cleanup_mock_web_api_server,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 from ...adapter_tests.socket_mode.mock_socket_mode_server import (
     start_socket_mode_server,
     stop_socket_mode_server_async,
@@ -29,7 +29,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/adapter_tests_async/test_async_sanic.py

@@ -17,7 +17,7 @@
     cleanup_mock_web_api_server,
     assert_auth_test_count,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestSanic:
@@ -39,7 +39,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/scenario_tests_async/test_app.py

@@ -19,7 +19,7 @@
     setup_mock_web_api_server,
     cleanup_mock_web_api_server,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestAsyncApp:
@@ -32,7 +32,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/scenario_tests_async/test_app_actor_user_token.py

@@ -23,7 +23,7 @@
     cleanup_mock_web_api_server,
     assert_auth_test_count_async,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestApp:
@@ -41,7 +41,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/scenario_tests_async/test_app_bot_only.py

@@ -22,7 +22,7 @@
     cleanup_mock_web_api_server,
     assert_auth_test_count_async,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestAppBotOnly:
@@ -40,7 +40,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/scenario_tests_async/test_app_custom_authorize.py

@@ -26,7 +26,7 @@
     cleanup_mock_web_api_server,
     assert_auth_test_count_async,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestAppCustomAuthorize:
@@ -44,7 +44,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)

tests/scenario_tests_async/test_app_dispatch.py

@@ -9,7 +9,7 @@
     setup_mock_web_api_server,
     cleanup_mock_web_api_server,
 )
-from tests.utils import remove_os_env_temporarily, restore_os_env
+from tests.utils import remove_os_env_temporarily, restore_os_env, get_event_loop
 
 
 class TestAsyncAppDispatch:
@@ -23,7 +23,7 @@ def event_loop(self):
         old_os_env = remove_os_env_temporarily()
         try:
             setup_mock_web_api_server(self)
-            loop = asyncio.get_event_loop()
+            loop = get_event_loop()
             yield loop
             loop.close()
             cleanup_mock_web_api_server(self)