Fix #721 Passing a global dict object without channel prop can cause issues among requests (#722)

Author: seratch

slack_bolt/context/say/async_say.py

@@ -1,6 +1,7 @@
 from typing import Optional, Union, Dict, Sequence
 
 from slack_bolt.context.say.internals import _can_say
+from slack_bolt.util.utils import create_copy
 from slack_sdk.models.attachments import Attachment
 from slack_sdk.models.blocks import Block
 from slack_sdk.web.async_client import AsyncWebClient
@@ -45,7 +46,7 @@ async def __call__(
                     **kwargs,
                 )
             elif isinstance(text_or_whole_response, dict):
-                message: dict = text_or_whole_response
+                message: dict = create_copy(text_or_whole_response)
                 if "channel" not in message:
                     message["channel"] = channel or self.channel
                 return await self.client.chat_postMessage(**message)

slack_bolt/context/say/say.py

@@ -6,6 +6,7 @@
 from slack_sdk.web import SlackResponse
 
 from slack_bolt.context.say.internals import _can_say
+from slack_bolt.util.utils import create_copy
 
 
 class Say:
@@ -46,7 +47,7 @@ def __call__(
                     **kwargs,
                 )
             elif isinstance(text_or_whole_response, dict):
-                message: dict = text_or_whole_response
+                message: dict = create_copy(text_or_whole_response)
                 if "channel" not in message:
                     message["channel"] = channel or self.channel
                 return self.client.chat_postMessage(**message)

tests/slack_bolt/context/test_say.py

@@ -43,3 +43,16 @@ def test_say_invalid(self):
         say = Say(client=self.web_client, channel="C111")
         with pytest.raises(ValueError):
             say([])
+
+    def test_say_shared_dict_as_arg(self):
+        # this shared dict object must not be modified by say method
+        shared_template_dict = {"text": "Hi there!"}
+        say = Say(client=self.web_client, channel="C111")
+        response: SlackResponse = say(shared_template_dict)
+        assert response.status_code == 200
+        assert shared_template_dict.get("channel") is None
+
+        say = Say(client=self.web_client, channel="C222")
+        response: SlackResponse = say(shared_template_dict)
+        assert response.status_code == 200
+        assert shared_template_dict.get("channel") is None

tests/slack_bolt_async/context/test_async_say.py

@@ -53,3 +53,17 @@ async def test_say_invalid(self):
         say = AsyncSay(client=self.web_client, channel="C111")
         with pytest.raises(ValueError):
             await say([])
+
+    @pytest.mark.asyncio
+    async def test_say_shared_dict_as_arg(self):
+        # this shared dict object must not be modified by say method
+        shared_template_dict = {"text": "Hi there!"}
+        say = AsyncSay(client=self.web_client, channel="C111")
+        response: AsyncSlackResponse = await say(shared_template_dict)
+        assert response.status_code == 200
+        assert shared_template_dict.get("channel") is None
+
+        say = AsyncSay(client=self.web_client, channel="C222")
+        response: AsyncSlackResponse = await say(shared_template_dict)
+        assert response.status_code == 200
+        assert shared_template_dict.get("channel") is None