Skip to content

Commit 4b5d354

Browse files
authored
Fix #757 by using Falcon 3.1.1 (#770)
* Fix #757 by using Falcon 3.1.1 * Fix
1 parent 365f765 commit 4b5d354

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

.github/workflows/tests.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,13 @@ jobs:
4848
- name: Run tests for HTTP Mode adapters (Django)
4949
run: |
5050
pytest tests/adapter_tests/django/
51-
# TODO: Enable testing with Falcon 4.x + Python 3.11
52-
# See also: https://github.com/slackapi/bolt-python/issues/757
5351
- name: Run tests for HTTP Mode adapters (Falcon 3.x)
5452
run: |
55-
if [ ${{ matrix.python-version }} != "3.11" ]; then
5653
pytest tests/adapter_tests/falcon/
57-
fi
5854
- name: Run tests for HTTP Mode adapters (Falcon 2.x)
5955
run: |
56+
# Falcon 2.x does not support Python 3.11 or newer
57+
# See also: https://github.com/slackapi/bolt-python/issues/757
6058
if [ ${{ matrix.python-version }} != "3.11" ]; then
6159
pip install "falcon<3"
6260
pytest tests/adapter_tests/falcon/
@@ -76,10 +74,6 @@ jobs:
7674
- name: Run tests for HTTP Mode adapters (asyncio-based libraries)
7775
run: |
7876
pip install -e ".[async]"
79-
pip install "falcon>=3,<4"
80-
if [ ${{ matrix.python-version }} == "3.11" ]; then
81-
# TODO: Enable testing with Falcon 4.x + Python 3.11
82-
# See also: https://github.com/slackapi/bolt-python/issues/757
83-
rm -f tests/adapter_tests_async/test_async_falcon.py
84-
fi
77+
# Falcon supports Python 3.11 since its v3.1.1
78+
pip install "falcon>=3.1.1,<4"
8579
pytest tests/adapter_tests_async/

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
"click>=7,<8", # for chalice
8282
"CherryPy>=18,<19",
8383
"Django>=3,<5",
84-
"falcon>=2,<4",
84+
"falcon>=3.1.1,<4" if sys.version_info.minor >= 11 else "falcon>=2,<4",
8585
"fastapi>=0.70.0,<1",
8686
"Flask>=1,<3",
8787
"Werkzeug>=2,<3",

0 commit comments

Comments
 (0)