Skip to content

Commit 4f1b4f8

Browse files
committed
Update tests to be clearer
1 parent 5c8e2f2 commit 4f1b4f8

File tree

4 files changed

+30
-15
lines changed

4 files changed

+30
-15
lines changed

tests/scenario_tests/test_message_changed.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,12 @@ def test_user_and_channel_id_in_context(self):
5353

5454
@app.event({"type": "message", "subtype": "message_changed"})
5555
def handle_message_changed(context):
56+
# These should come from the main event payload part
5657
assert context.channel_id == "C111"
5758
assert context.user_id == "U111"
59+
# The following ones come from authorizations[0]
60+
assert context.team_id == "T-auth"
61+
assert context.enterprise_id == "E-auth"
5862

5963
request = self.build_request(event_payload)
6064
response = app.dispatch(request)
@@ -108,13 +112,13 @@ def handle_message_changed(context):
108112
"event_time": 1665102362,
109113
"authorizations": [
110114
{
111-
"enterprise_id": "E111",
112-
"team_id": "T111",
113-
"user_id": "U111",
115+
"enterprise_id": "E-auth",
116+
"team_id": "T-auth",
117+
"user_id": "U-auth",
114118
"is_bot": True,
115119
"is_enterprise_install": False,
116120
}
117121
],
118122
"is_ext_shared_channel": False,
119-
"event_context": "1-message-T111-C111",
123+
"event_context": "1-message-T-auth-C111",
120124
}

tests/scenario_tests/test_message_deleted.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,12 @@ def test_user_and_channel_id_in_context(self):
5353

5454
@app.event({"type": "message", "subtype": "message_deleted"})
5555
def handle_message_deleted(context):
56+
# These should come from the main event payload part
5657
assert context.channel_id == "C111"
5758
assert context.user_id == "U111"
59+
# The following ones come from authorizations[0]
60+
assert context.team_id == "T-auth"
61+
assert context.enterprise_id == "E-auth"
5862

5963
request = self.build_request(event_payload)
6064
response = app.dispatch(request)
@@ -88,9 +92,9 @@ def handle_message_deleted(context):
8892
"event_time": 1665368629,
8993
"authorizations": [
9094
{
91-
"enterprise_id": "E111",
92-
"team_id": "T111",
93-
"user_id": "U111",
95+
"enterprise_id": "E-auth",
96+
"team_id": "T-auth",
97+
"user_id": "U-auth",
9498
"is_bot": True,
9599
"is_enterprise_install": False,
96100
}

tests/scenario_tests_async/test_message_changed.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,12 @@ async def test_user_and_channel_id_in_context(self):
6060

6161
@app.event({"type": "message", "subtype": "message_changed"})
6262
async def handle_message_changed(context):
63+
# These should come from the main event payload part
6364
assert context.channel_id == "C111"
6465
assert context.user_id == "U111"
66+
# The following ones come from authorizations[0]
67+
assert context.team_id == "T-auth"
68+
assert context.enterprise_id == "E-auth"
6569

6670
request = self.build_request(event_payload)
6771
response = await app.async_dispatch(request)
@@ -115,9 +119,9 @@ async def handle_message_changed(context):
115119
"event_time": 1665102362,
116120
"authorizations": [
117121
{
118-
"enterprise_id": "E111",
119-
"team_id": "T111",
120-
"user_id": "U111",
122+
"enterprise_id": "E-auth",
123+
"team_id": "T-auth",
124+
"user_id": "U-auth",
121125
"is_bot": True,
122126
"is_enterprise_install": False,
123127
}

tests/scenario_tests_async/test_message_deleted.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,13 @@ async def test_user_and_channel_id_in_context(self):
5959
app = AsyncApp(client=self.web_client, signing_secret=self.signing_secret, process_before_response=True)
6060

6161
@app.event({"type": "message", "subtype": "message_deleted"})
62-
async def handle_message_deleted(context, logger):
63-
logger.error(context.user_id)
62+
async def handle_message_deleted(context):
63+
# These should come from the main event payload part
6464
assert context.channel_id == "C111"
6565
assert context.user_id == "U111"
66+
# The following ones come from authorizations[0]
67+
assert context.team_id == "T-auth"
68+
assert context.enterprise_id == "E-auth"
6669

6770
request = self.build_request(event_payload)
6871
response = await app.async_dispatch(request)
@@ -96,9 +99,9 @@ async def handle_message_deleted(context, logger):
9699
"event_time": 1665368629,
97100
"authorizations": [
98101
{
99-
"enterprise_id": "E111",
100-
"team_id": "T111",
101-
"user_id": "U111",
102+
"enterprise_id": "E-auth",
103+
"team_id": "T-auth",
104+
"user_id": "U-auth",
102105
"is_bot": True,
103106
"is_enterprise_install": False,
104107
}

0 commit comments

Comments
 (0)