Skip to content

Commit 9c26945

Browse files
test: add tests around the logger experience of bolt (#1270)
1 parent 797f032 commit 9c26945

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

tests/scenario_tests/test_web_client_customization.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import json
2+
import logging
23
from time import time
34
from urllib.parse import quote
45

@@ -21,6 +22,7 @@ class TestWebClientCustomization:
2122
signing_secret = "secret"
2223
mock_api_server_base_url = "http://localhost:8888"
2324
signature_verifier = SignatureVerifier(signing_secret)
25+
test_logger = logging.getLogger("test.logger")
2426
web_client = WebClient(
2527
token=valid_token,
2628
base_url=mock_api_server_base_url,
@@ -69,6 +71,20 @@ def listener(ack, client):
6971
assert response.body == ""
7072
assert_auth_test_count(self, 1)
7173

74+
def test_web_client_logger_is_default_app_logger(self):
75+
app = App(token=self.valid_token, signing_secret=self.signing_secret, token_verification_enabled=False)
76+
assert app.client._logger == app.logger # TODO: use client.logger when available
77+
78+
def test_web_client_logger_is_app_logger(self):
79+
app = App(
80+
token=self.valid_token,
81+
signing_secret=self.signing_secret,
82+
logger=self.test_logger,
83+
token_verification_enabled=False,
84+
)
85+
assert app.client._logger == app.logger # TODO: use client.logger when available
86+
assert app.client._logger == self.test_logger # TODO: use client.logger when available
87+
7288

7389
block_actions_body = {
7490
"type": "block_actions",

tests/scenario_tests_async/test_web_client_customization.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import json
2+
import logging
23
import os
34
from time import time
45
from urllib.parse import quote
@@ -23,6 +24,7 @@ class TestWebClientCustomization:
2324
signing_secret = "secret"
2425
mock_api_server_base_url = "http://localhost:8888"
2526
signature_verifier = SignatureVerifier(signing_secret)
27+
test_logger = logging.getLogger("test.logger")
2628
web_client = AsyncWebClient(
2729
token=valid_token,
2830
base_url=mock_api_server_base_url,
@@ -87,6 +89,15 @@ async def listener(ack, client):
8789
assert response.body == ""
8890
await assert_auth_test_count_async(self, 1)
8991

92+
def test_web_client_logger_is_default_app_logger(self):
93+
app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret)
94+
assert app.client._logger == app.logger # TODO: use client.logger when available
95+
96+
def test_web_client_logger_is_app_logger(self):
97+
app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret, logger=self.test_logger)
98+
assert app.client._logger == app.logger # TODO: use client.logger when available
99+
assert app.client._logger == self.test_logger # TODO: use client.logger when available
100+
90101

91102
block_actions_body = {
92103
"type": "block_actions",

0 commit comments

Comments
 (0)