Upgrade pytype to the latest (#496)

Author: seratch

.github/workflows/ci-build.yml

@@ -72,10 +72,7 @@ jobs:
       run: |
         python_version=`python -V`
         if [ ${python_version:7:3} == "3.8" ]; then
-          pip install -e ".[async]"
-          pip install -e ".[adapter]"
-          # TODO: upgrade pytype
-          pip install "pytype==2021.9.27" && pytype slack_bolt/
+          ./scripts/run_pytype.sh
         fi
     - name: Run all tests for codecov (3.9 only)
       run: |

scripts/run_pytype.sh

@@ -3,7 +3,7 @@
 
 script_dir=$(dirname $0)
 cd ${script_dir}/.. && \
+  pip install -e ".[async]" && \
   pip install -e ".[adapter]" && \
-  # TODO: upgrade pytype
-  pip install "pytype==2021.9.27" && \
+  pip install "pytype==2021.10.11" && \
   pytype slack_bolt/

slack_bolt/app/app.py

@@ -179,7 +179,7 @@ def message_hello(message, say):
             listener_executor: Custom executor to run background tasks. If absent, the default `ThreadPoolExecutor` will
                 be used.
         """
-        signing_secret = signing_secret or os.environ.get("SLACK_SIGNING_SECRET")
+        signing_secret = signing_secret or os.environ.get("SLACK_SIGNING_SECRET", "")
         token = token or os.environ.get("SLACK_BOT_TOKEN")
 
         self._name: str = name or inspect.stack()[1].filename.split(os.path.sep)[-1]
@@ -304,7 +304,7 @@ def message_hello(message, say):
         # Middleware Initialization
         # --------------------------------------
 
-        self._middleware_list: List[Union[Callable, Middleware]] = []
+        self._middleware_list: List[Middleware] = []
         self._listeners: List[Listener] = []
 
         if listener_executor is None:
@@ -469,7 +469,7 @@ def dispatch(self, req: BoltRequest) -> BoltResponse:
         starting_time = time.time()
         self._init_context(req)
 
-        resp: BoltResponse = BoltResponse(status=200, body="")
+        resp: Optional[BoltResponse] = BoltResponse(status=200, body="")
         middleware_state = {"next_called": False}
 
         def middleware_next():
@@ -607,7 +607,8 @@ def middleware_func(logger, body, next):
         if len(args) > 0:
             middleware_or_callable = args[0]
             if isinstance(middleware_or_callable, Middleware):
-                self._middleware_list.append(middleware_or_callable)
+                middleware: Middleware = middleware_or_callable
+                self._middleware_list.append(middleware)
             elif isinstance(middleware_or_callable, Callable):
                 self._middleware_list.append(
                     CustomMiddleware(app_name=self.name, func=middleware_or_callable)

slack_bolt/app/async_app.py

@@ -183,7 +183,7 @@ async def message_hello(message, say):  # async function
             oauth_flow: Instantiated `slack_bolt.oauth.AsyncOAuthFlow`. This is always prioritized over oauth_settings.
             verification_token: Deprecated verification mechanism. This can used only for ssl_check requests.
         """
-        signing_secret = signing_secret or os.environ.get("SLACK_SIGNING_SECRET")
+        signing_secret = signing_secret or os.environ.get("SLACK_SIGNING_SECRET", "")
         token = token or os.environ.get("SLACK_BOT_TOKEN")
 
         self._name: str = name or inspect.stack()[1].filename.split(os.path.sep)[-1]
@@ -327,7 +327,7 @@ async def message_hello(message, say):  # async function
         # Middleware Initialization
         # --------------------------------------
 
-        self._async_middleware_list: List[Union[Callable, AsyncMiddleware]] = []
+        self._async_middleware_list: List[AsyncMiddleware] = []
         self._async_listeners: List[AsyncListener] = []
 
         self._process_before_response = process_before_response
@@ -506,7 +506,7 @@ async def async_dispatch(self, req: AsyncBoltRequest) -> BoltResponse:
         starting_time = time.time()
         self._init_context(req)
 
-        resp: BoltResponse = BoltResponse(status=200, body="")
+        resp: Optional[BoltResponse] = BoltResponse(status=200, body="")
         middleware_state = {"next_called": False}
 
         async def async_middleware_next():
@@ -642,7 +642,8 @@ async def middleware_func(logger, body, next):
         if len(args) > 0:
             middleware_or_callable = args[0]
             if isinstance(middleware_or_callable, AsyncMiddleware):
-                self._async_middleware_list.append(middleware_or_callable)
+                middleware: AsyncMiddleware = middleware_or_callable
+                self._async_middleware_list.append(middleware)
             elif isinstance(middleware_or_callable, Callable):
                 self._async_middleware_list.append(
                     AsyncCustomMiddleware(

slack_bolt/app/async_server.py

@@ -29,7 +29,7 @@ def __init__(  # type:ignore
         """
         self.port = port
         self.path = path
-        self.bolt_app: "AsyncApp" = app
+        self.bolt_app: "AsyncApp" = app  # type: ignore
         self.web_app = web.Application()
         self._bolt_oauth_flow = self.bolt_app.oauth_flow
         if self._bolt_oauth_flow: