remove save_callback_id, fix callback def typo + doc string grammar

Author: misscoded

slack_bolt/app/app.py

@@ -352,19 +352,17 @@ def middleware(self, *args) -> None:
     def step(
         self,
         callback_id: Union[str, Pattern, WorkflowStep],
-        save_callback_id: Optional[Union[str, Pattern]] = None,
         edit: Optional[Union[Callable[..., Optional[BoltResponse]], Listener]] = None,
         save: Optional[Union[Callable[..., Optional[BoltResponse]], Listener]] = None,
         execute: Optional[
             Union[Callable[..., Optional[BoltResponse]], Listener]
         ] = None,
     ):
-        """Registers a new Workflow Steps from Apps listeners."""
+        """Registers a new Workflow Step listener"""
         step = callback_id
         if isinstance(callback_id, (str, Pattern)):
             step = WorkflowStep(
                 callback_id=callback_id,
-                save_callback_id=save_callback_id,
                 edit=edit,
                 save=save,
                 execute=execute,

slack_bolt/app/async_app.py

@@ -364,7 +364,6 @@ def middleware(self, *args) -> None:
     def step(
         self,
         callback_id: Union[str, Pattern, AsyncWorkflowStep],
-        save_callback_id: Optional[Union[str, Pattern]] = None,
         edit: Optional[
             Union[Callable[..., Optional[BoltResponse]], AsyncListener]
         ] = None,
@@ -375,12 +374,11 @@ def step(
             Union[Callable[..., Optional[BoltResponse]], AsyncListener]
         ] = None,
     ):
-        """Registers a new Workflow Steps from Apps listeners."""
+        """Registers a new Workflow Step listener"""
         step = callback_id
         if isinstance(callback_id, (str, Pattern)):
             step = AsyncWorkflowStep(
                 callback_id=callback_id,
-                save_callback_id=save_callback_id,
                 edit=edit,
                 save=save,
                 execute=execute,

slack_bolt/workflows/step/async_step.py

@@ -29,15 +29,12 @@ def __init__(
         edit: Union[Callable[..., Awaitable[BoltResponse]], AsyncListener],
         save: Union[Callable[..., Awaitable[BoltResponse]], AsyncListener],
         execute: Union[Callable[..., Awaitable[BoltResponse]], AsyncListener],
-        save_callback_id: Optional[str] = None,  # TODO: better approach?
         app_name: Optional[str] = None,
     ):
         self.callback_id = callback_id
         app_name = app_name or __name__
         self.edit = self._build_listener(callback_id, app_name, edit, "edit")
-        self.save = self._build_listener(
-            save_callback_id or callback_id, app_name, save, "save"
-        )
+        self.save = self._build_listener(callback_id, app_name, save, "save")
         self.execute = self._build_listener(callback_id, app_name, execute, "execute")
 
     @classmethod
@@ -125,7 +122,7 @@ async def save_listener_middleware(
 
 
 def _build_execute_listener_middleware():
-    async def save_listener_middleware(
+    async def execute_listener_middleware(
         context: AsyncBoltContext,
         client: AsyncWebClient,
         body: dict,
@@ -135,4 +132,4 @@ async def save_listener_middleware(
         context["fail"] = AsyncFail(client=client, body=body,)
         return await next()
 
-    return AsyncCustomMiddleware(app_name=__name__, func=save_listener_middleware)
+    return AsyncCustomMiddleware(app_name=__name__, func=execute_listener_middleware)

slack_bolt/workflows/step/step.py

@@ -29,16 +29,14 @@ def __init__(
         edit: Union[Callable[..., Optional[BoltResponse]], Listener],
         save: Union[Callable[..., Optional[BoltResponse]], Listener],
         execute: Union[Callable[..., Optional[BoltResponse]], Listener],
-        save_callback_id: Optional[str] = None,  # TODO: better approach?
         app_name: Optional[str] = None,
     ):
         self.callback_id = callback_id
         app_name = app_name or __name__
         self.edit = self._build_listener(callback_id, app_name, edit, "edit")
-        self.save = self._build_listener(
-            save_callback_id or callback_id, app_name, save, "save"
-        )
-        self.execute = self._build_listener(callback_id, app_name, execute, "execute")
+        self.save = self._build_listener(callback_id, app_name, save, "save")
+        self.execute = self._build_listener(
+            callback_id, app_name, execute, "execute")
 
     @classmethod
     def _build_listener(cls, callback_id, app_name, listener, name):
@@ -123,7 +121,7 @@ def save_listener_middleware(
 
 
 def _build_execute_listener_middleware():
-    def save_listener_middleware(
+    def execute_listener_middleware(
         context: BoltContext,
         client: WebClient,
         body: dict,
@@ -133,4 +131,4 @@ def save_listener_middleware(
         context["fail"] = Fail(client=client, body=body,)
         return next()
 
-    return CustomMiddleware(app_name=__name__, func=save_listener_middleware)
+    return CustomMiddleware(app_name=__name__, func=execute_listener_middleware)