Fix #763 by improving the suggestion logging for view_closed patterns (#766)

* Fix #763 by improving the suggestion logging for view_closed patterns

Author: seratch

slack_bolt/logger/messages.py

@@ -10,7 +10,8 @@
     is_options,
     is_shortcut,
     is_slash_command,
-    is_view,
+    is_view_submission,
+    is_view_closed,
     is_workflow_step_edit,
     is_workflow_step_save,
     is_workflow_step_execute,
@@ -241,13 +242,24 @@ def warning_unhandled_request(  # type: ignore
     logger.info(body)
 """,
         )
-    if is_view(req.body):
+    if is_view_submission(req.body):
         # @app.view
         return _build_unhandled_request_suggestion(
             default_message,
             f"""
 @app.view("{req.body.get('view', {}).get('callback_id', 'modal-view-id')}")
-{'async ' if is_async else ''}def handle_view_events(ack, body, logger):
+{'async ' if is_async else ''}def handle_view_submission_events(ack, body, logger):
+    {'await ' if is_async else ''}ack()
+    logger.info(body)
+""",
+        )
+    if is_view_closed(req.body):
+        # @app.view
+        return _build_unhandled_request_suggestion(
+            default_message,
+            f"""
+@app.view_closed("{req.body.get('view', {}).get('callback_id', 'modal-view-id')}")
+{'async ' if is_async else ''}def handle_view_closed_events(ack, body, logger):
     {'await ' if is_async else ''}ack()
     logger.info(body)
 """,

tests/slack_bolt/logger/test_unmatched_suggestions.py

@@ -153,7 +153,7 @@ def test_view(self):
 [Suggestion] You can handle this type of event with the following listener function:
 
 @app.view("view-id")
-def handle_view_events(ack, body, logger):
+def handle_view_submission_events(ack, body, logger):
     ack()
     logger.info(body)
 """
@@ -171,8 +171,8 @@ def handle_view_events(ack, body, logger):
 ---
 [Suggestion] You can handle this type of event with the following listener function:
 
-@app.view("view-id")
-def handle_view_events(ack, body, logger):
+@app.view_closed("view-id")
+def handle_view_closed_events(ack, body, logger):
     ack()
     logger.info(body)
 """

tests/slack_bolt_async/logger/test_unmatched_suggestions.py

@@ -153,7 +153,7 @@ def test_view(self):
 [Suggestion] You can handle this type of event with the following listener function:
 
 @app.view("view-id")
-async def handle_view_events(ack, body, logger):
+async def handle_view_submission_events(ack, body, logger):
     await ack()
     logger.info(body)
 """
@@ -171,8 +171,8 @@ async def handle_view_events(ack, body, logger):
 ---
 [Suggestion] You can handle this type of event with the following listener function:
 
-@app.view("view-id")
-async def handle_view_events(ack, body, logger):
+@app.view_closed("view-id")
+async def handle_view_closed_events(ack, body, logger):
     await ack()
     logger.info(body)
 """