Fix #1212 Fails to parse channel_email_addresses in admin.conversations.search API response (#1214)

* Fix #1212 Fails to parse channel_email_addresses in admin.conversations.search API response

* Fix tests

Author: seratch

json-logs/samples/api/admin.conversations.search.json

@@ -25,11 +25,24 @@
       ],
       "is_pending_ext_shared": false,
       "connected_team_ids": [
-        ""
+        "",
+        "T00000000"
       ],
       "conversation_host_id": "E00000000",
       "channel_email_addresses": [
-        ""
+        {
+          "team_id": "T00000000",
+          "user_id": "W00000000",
+          "conversation_id": "C00000000",
+          "date_created": 12345,
+          "address": "",
+          "name": "",
+          "icons": {
+            "image_36": "https://www.example.com/",
+            "image_48": "https://www.example.com/",
+            "image_72": "https://www.example.com/"
+          }
+        }
       ],
       "connected_limited_team_ids": [
         ""
@@ -56,5 +69,10 @@
   "error": "",
   "needed": "",
   "provided": "",
-  "total_count": 12345
+  "total_count": 12345,
+  "response_metadata": {
+    "messages": [
+      ""
+    ]
+  }
 }

slack-api-client/src/main/java/com/slack/api/methods/response/admin/conversations/AdminConversationsSearchResponse.java

@@ -1,6 +1,7 @@
 package com.slack.api.methods.response.admin.conversations;
 
 import com.slack.api.methods.SlackApiTextResponse;
+import com.slack.api.model.ChannelEmailAddress;
 import com.slack.api.model.ErrorResponseMetadata;
 import lombok.Data;
 
@@ -48,7 +49,7 @@ public static class Conversation {
         private List<String> pendingConnectedTeamIds;
         private List<String> connectedTeamIds;
         private List<String> connectedLimitedTeamIds;
-        private List<String> channelEmailAddresses;
+        private List<ChannelEmailAddress> channelEmailAddresses;
         private String contextTeamId;
         private Boolean isPendingExtShared;
         private Boolean isDisconnectInProgress;

slack-api-client/src/test/java/test_locally/api/methods/FieldValidation_a_to_c_Test.java

@@ -415,7 +415,8 @@ void validateConversation(Conversation conversation) throws Exception {
                 "getPendingConnectedTeamIds",
                 "getConnectedLimitedTeamIds",
                 "getIsUserDeleted",
-                "getProperties"
+                "getProperties",
+                "getChannelEmailAddresses"
         );
     }
 
@@ -528,7 +529,8 @@ public void conversations_commands() throws Exception {
                     "getParentUserId",
                     "getBotProfile",
                     "getIsUserDeleted",
-                    "getProperties"
+                    "getProperties",
+                    "getChannelEmailAddresses"
             );
         }
         {

slack-api-client/src/test/java/test_with_remote_apis/methods_admin_api/AdminApi_conversations_Test.java

@@ -31,6 +31,7 @@
 
 import static org.hamcrest.CoreMatchers.*;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.greaterThan;
 
 @Slf4j
 public class AdminApi_conversations_Test {
@@ -56,25 +57,23 @@ public static void tearDown() throws InterruptedException {
     public void search() throws Exception {
         if (orgAdminUserToken != null) {
             AdminConversationsSearchResponse search = methodsAsync.adminConversationsSearch(r -> r
-                    .limit(1)
+                    .limit(20)
                     .sort("member_count")
                     .sortDir("desc")
                     .searchChannelTypes(Arrays.asList("exclude_archived", "private_exclude"))
             ).get();
             assertThat(search.getError(), is(nullValue()));
-            // TODO: 2023-09-26: unexpectedly zero result
-            assertThat(search.getConversations().size(), is(1));
+            assertThat(search.getConversations().size(), is(greaterThan(0)));
 
             AdminConversationsSearchResponse search2 = methodsAsync.adminConversationsSearch(r -> r
-                    .limit(1)
+                    .limit(20)
                     .sort("member_count")
                     .sortDir("desc")
                     .searchChannelTypes(Arrays.asList("exclude_archived", "private_exclude"))
                     .cursor(search.getNextCursor())
             ).get();
             assertThat(search2.getError(), is(nullValue()));
-            // TODO: 2023-09-26: unexpectedly zero result
-            assertThat(search2.getConversations().size(), is(1));
+            assertThat(search2.getConversations().size(), is(greaterThan(1)));
         }
     }
 

slack-api-model/src/main/java/com/slack/api/model/ChannelEmailAddress.java

@@ -0,0 +1,25 @@
+package com.slack.api.model;
+
+import com.google.gson.annotations.SerializedName;
+import lombok.Data;
+
+@Data
+public class ChannelEmailAddress {
+    private String teamId;
+    private String userId;
+    private String conversationId;
+    private Integer dateCreated;
+    private String address;
+    private String name;
+    private Icons icons;
+
+    @Data
+    public static class Icons {
+        @SerializedName("image_36")
+        private String image36;
+        @SerializedName("image_48")
+        private String image48;
+        @SerializedName("image_72")
+        private String image72;
+    }
+}

slack-api-model/src/main/java/com/slack/api/model/Conversation.java

@@ -62,6 +62,7 @@ public class Conversation {
     private List<String> internalTeamIds;
     private List<String> connectedTeamIds;
     private List<String> connectedLimitedTeamIds;
+    private List<ChannelEmailAddress> channelEmailAddresses;
 
     private String contextTeamId;