Skip to content

Commit 1e64a67

Browse files
committed
Move UsersLookupByEmailResponse to the right package without any breaking changes
1 parent 6bd91d6 commit 1e64a67

File tree

9 files changed

+28
-4
lines changed

9 files changed

+28
-4
lines changed

slack-api-client/src/main/java/com/slack/api/methods/AsyncMethodsClient.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@
9090
import com.slack.api.methods.response.calls.CallsInfoResponse;
9191
import com.slack.api.methods.response.calls.CallsUpdateResponse;
9292
import com.slack.api.methods.response.calls.participants.CallsParticipantsAddResponse;
93-
import com.slack.api.methods.response.channels.UsersLookupByEmailResponse;
9493
import com.slack.api.methods.response.chat.*;
9594
import com.slack.api.methods.response.chat.scheduled_messages.ChatScheduledMessagesListResponse;
9695
import com.slack.api.methods.response.conversations.*;

slack-api-client/src/main/java/com/slack/api/methods/MethodsClient.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@
153153
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersListResponse;
154154
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersUpdateResponse;
155155
import com.slack.api.methods.response.users.*;
156+
import com.slack.api.methods.response.users.UsersLookupByEmailResponse;
156157
import com.slack.api.methods.response.users.profile.UsersProfileGetResponse;
157158
import com.slack.api.methods.response.users.profile.UsersProfileSetResponse;
158159
import com.slack.api.methods.response.views.ViewsOpenResponse;

slack-api-client/src/main/java/com/slack/api/methods/impl/AsyncMethodsClientImpl.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,6 @@
9494
import com.slack.api.methods.response.calls.CallsInfoResponse;
9595
import com.slack.api.methods.response.calls.CallsUpdateResponse;
9696
import com.slack.api.methods.response.calls.participants.CallsParticipantsAddResponse;
97-
import com.slack.api.methods.response.channels.UsersLookupByEmailResponse;
9897
import com.slack.api.methods.response.chat.*;
9998
import com.slack.api.methods.response.chat.scheduled_messages.ChatScheduledMessagesListResponse;
10099
import com.slack.api.methods.response.conversations.*;

slack-api-client/src/main/java/com/slack/api/methods/impl/MethodsClientImpl.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,7 @@
155155
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersListResponse;
156156
import com.slack.api.methods.response.usergroups.users.UsergroupsUsersUpdateResponse;
157157
import com.slack.api.methods.response.users.*;
158+
import com.slack.api.methods.response.users.UsersLookupByEmailResponse;
158159
import com.slack.api.methods.response.users.profile.UsersProfileGetResponse;
159160
import com.slack.api.methods.response.users.profile.UsersProfileSetResponse;
160161
import com.slack.api.methods.response.views.ViewsOpenResponse;

slack-api-client/src/main/java/com/slack/api/methods/response/channels/UsersLookupByEmailResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import com.slack.api.model.User;
55
import lombok.Data;
66

7+
@Deprecated // use com.slack.api.methods.response.users.UsersLookupByEmailResponse instead
78
@Data
89
public class UsersLookupByEmailResponse implements SlackApiResponse {
910

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
package com.slack.api.methods.response.users;
2+
3+
public class UsersLookupByEmailResponse extends com.slack.api.methods.response.channels.UsersLookupByEmailResponse {
4+
}

slack-api-client/src/test/java/test_locally/api/methods/FieldValidation_o_to_z_Test.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package test_locally.api.methods;
22

3-
import com.slack.api.methods.response.channels.UsersLookupByEmailResponse;
43
import com.slack.api.methods.response.oauth.OAuthAccessResponse;
54
import com.slack.api.methods.response.oauth.OAuthTokenResponse;
65
import com.slack.api.methods.response.oauth.OAuthV2AccessResponse;
@@ -458,6 +457,14 @@ public void users_lookupByEmail() throws Exception {
458457
verifyIfAllGettersReturnNonNull(obj);
459458
}
460459

460+
// NOTE: com.slack.api.methods.response.channels.UsersLookupByEmailResponse will be removed in v1.1
461+
@Test
462+
public void users_lookupByEmail_deprecation() throws Exception {
463+
com.slack.api.methods.response.channels.UsersLookupByEmailResponse obj =
464+
parse("users.lookupByEmail", com.slack.api.methods.response.channels.UsersLookupByEmailResponse.class);
465+
verifyIfAllGettersReturnNonNull(obj);
466+
}
467+
461468
@Test
462469
public void users_profile_get() throws Exception {
463470
UsersProfileGetResponse obj = parse("users.profile.get", UsersProfileGetResponse.class);

slack-api-client/src/test/java/test_locally/api/methods/UsersTest.java

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import com.slack.api.Slack;
44
import com.slack.api.SlackConfig;
5+
import com.slack.api.methods.response.users.UsersLookupByEmailResponse;
56
import org.junit.After;
67
import org.junit.Before;
78
import org.junit.Test;
@@ -84,4 +85,15 @@ public void test_async() throws Exception {
8485
.get().isOk(), is(true));
8586
}
8687

88+
// NOTE: we can safely remove this tests since v1.1
89+
@Test
90+
public void test_deprecated_UsersLookupByEmailResponse() throws Exception {
91+
UsersLookupByEmailResponse response = slack.methods(ValidToken).usersLookupByEmail(r -> r.email("[email protected]"));
92+
assertThat(response.isOk(), is(true));
93+
// for backward-compatibility
94+
com.slack.api.methods.response.channels.UsersLookupByEmailResponse deprecatedResponse
95+
= slack.methods(ValidToken).usersLookupByEmail(r -> r.email("[email protected]"));
96+
assertThat(deprecatedResponse.isOk(), is(true));
97+
}
98+
8799
}

slack-api-client/src/test/java/test_with_remote_apis/methods/users_Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import com.slack.api.methods.SlackApiException;
55
import com.slack.api.methods.request.users.UsersLookupByEmailRequest;
66
import com.slack.api.methods.request.users.UsersSetActiveRequest;
7-
import com.slack.api.methods.response.channels.UsersLookupByEmailResponse;
7+
import com.slack.api.methods.response.users.UsersLookupByEmailResponse;
88
import com.slack.api.methods.response.users.*;
99
import com.slack.api.model.User;
1010
import config.Constants;

0 commit comments

Comments
 (0)