Skip to content

Commit 2ae1fa3

Browse files
committed
Run all the integration tests - 2024-07-01 PT
1 parent e1b7a42 commit 2ae1fa3

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

json-logs/samples/api/files.completeUploadExternal.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@
9494
}
9595
},
9696
"channels": [
97-
"C00000000"
97+
"C00000000",
98+
""
9899
],
99100
"groups": [
100101
""

json-logs/samples/api/users.discoverableContacts.lookup.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
"error": "",
44
"needed": "",
55
"provided": "",
6-
"user": {
7-
"is_discoverable": false
8-
},
96
"response_metadata": {
107
"messages": [
118
""
129
]
13-
}
10+
},
11+
"is_discoverable": false
1412
}

slack-api-client/src/main/java/com/slack/api/methods/response/users/discoverable_contacts/UsersDiscoverableContactsLookupResponse.java

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.slack.api.methods.response.users.discoverable_contacts;
22

3-
import com.google.gson.annotations.SerializedName;
43
import com.slack.api.methods.SlackApiTextResponse;
54
import com.slack.api.model.ResponseMetadata;
65
import lombok.Data;
@@ -18,13 +17,6 @@ public class UsersDiscoverableContactsLookupResponse implements SlackApiTextResp
1817
private String provided;
1918
private transient Map<String, List<String>> httpResponseHeaders;
2019

21-
private UserContact user;
22-
20+
private Boolean isDiscoverable;
2321
private ResponseMetadata responseMetadata;
24-
25-
@Data
26-
public static class UserContact {
27-
@SerializedName("is_discoverable")
28-
private boolean discoverable;
29-
}
3022
}

slack-api-client/src/test/java/test_with_remote_apis/methods/users_Test.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,8 +451,7 @@ public void discoverableContacts() throws Exception {
451451
String email = user.getUser().getProfile().getEmail();
452452
UsersDiscoverableContactsLookupResponse response = slack.methods(orgBotToken)
453453
.usersDiscoverableContactsLookup(r -> r.email(email));
454-
// TODO: valid tests
455-
assertThat(response.getError(), is("not_allowed"));
454+
assertThat(response.getError(), is(nullValue()));
456455
}
457456

458457
@Test

0 commit comments

Comments
 (0)