Mitigate #757: when creating the AuthTestMockServer, do not use a privileged port number (less than 1024). (#800)

Author: filmaj

bolt-aws-lambda/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt-helidon/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt-http4k/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt-ktor/src/test/kotlin/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt-micronaut/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt-socket-mode/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

bolt/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

slack-api-client/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;

slack-app-backend/src/test/java/util/PortProvider.java

@@ -11,6 +11,7 @@ public class PortProvider {
     private PortProvider() {
     }
 
+    private static final int MINIMUM = 1024;
     private static final SecureRandom RANDOM = new SecureRandom();
     private static final ConcurrentMap<String, Integer> PORTS = new ConcurrentHashMap<>();
 
@@ -21,8 +22,8 @@ public static int getPort(String name) {
     private static int randomPort() {
         while (true) {
             int randomPort = RANDOM.nextInt(9999);
-            if (randomPort < 1000) {
-                randomPort += 1000;
+            if (randomPort < MINIMUM) {
+                randomPort += MINIMUM;
             }
             if (isAvailable(randomPort)) {
                 return randomPort;