Run all the integration tests - 2023-09-25 PT

Author: seratch

json-logs/raw/audit/v1/actions.json

@@ -293,7 +293,11 @@
       "app_datastore_updated",
       "app_datastore_deleted",
       "app_collaborator_added",
-      "app_collaborator_removed"
+      "app_collaborator_removed",
+      "app_deleted",
+      "app_variable_added",
+      "app_variable_removed",
+      "app_deployed"
     ],
     "workflow_builder": [
       "workflow_created",
@@ -393,6 +397,11 @@
       "canvas_shared",
       "canvas_tombstoned",
       "canvas_unshared"
+    ],
+    "function": [
+      "function_distribution_permission_added",
+      "function_distribution_permission_removed",
+      "function_distribution_permission_set"
     ]
   }
 }

json-logs/raw/audit/v1/schemas.json

@@ -120,6 +120,15 @@
         "updated_by": "string",
         "step_configuration": "vec\u003cdict\u003cstring, mixed\u003e\u003e"
       }
+    },
+    {
+      "type": "app",
+      "app": {
+        "id": "string",
+        "app_id": "string",
+        "distribution_type": "string",
+        "user_ids": "array"
+      }
     }
   ]
 }

json-logs/samples/audit/v1/actions.json

@@ -50,6 +50,9 @@
     ],
     "canvas": [
       ""
+    ],
+    "function": [
+      ""
     ]
   },
   "ok": false,

json-logs/samples/audit/v1/logs.json

@@ -103,6 +103,15 @@
           "restricted_subjects": [
             ""
           ]
+        },
+        "workflow_v2": {
+          "id": "",
+          "app_id": "",
+          "date_updated": 123,
+          "callback_id": "",
+          "name": "",
+          "updated_by": "",
+          "step_configuration": []
         }
       },
       "context": {
@@ -276,7 +285,8 @@
         },
         "url_private": "",
         "shared_with": {
-          "channel_id": ""
+          "channel_id": "",
+          "access_level": ""
         },
         "initiated_by": "",
         "source_team": "",
@@ -338,7 +348,11 @@
         "target_entity_id": "",
         "changed_permissions": [],
         "datastore_name": "",
-        "attributes": []
+        "attributes": [],
+        "channel": "",
+        "entity_type": "",
+        "actor": "",
+        "access_level": ""
       }
     }
   ]

json-logs/samples/audit/v1/schemas.json

@@ -38,7 +38,10 @@
         "is_distributed": "",
         "is_directory_approved": "",
         "is_workflow_app": "",
-        "scopes": ""
+        "scopes": "",
+        "app_id": "",
+        "distribution_type": "",
+        "user_ids": ""
       },
       "workflow": {
         "id": "",

slack-api-client/src/main/java/com/slack/api/audit/Actions.java

@@ -321,6 +321,10 @@ private App() {
         public static final String app_allowlist_rule_matched = "app_allowlist_rule_matched";
         public static final String app_collaborator_added = "app_collaborator_added";
         public static final String app_collaborator_removed = "app_collaborator_removed";
+        public static final String app_deleted = "app_deleted";
+        public static final String app_variable_added = "app_variable_added";
+        public static final String app_variable_removed = "app_variable_removed";
+        public static final String app_deployed = "app_deployed";
     }
 
     public static class Message {
@@ -470,4 +474,13 @@ private Canvas() {
         public static final String canvas_tombstoned = "canvas_tombstoned";
         public static final String canvas_unshared = "canvas_unshared";
     }
+
+    public static class Function {
+        private Function() {
+        }
+
+        public static final String function_distribution_permission_added = "function_distribution_permission_added";
+        public static final String function_distribution_permission_removed = "function_distribution_permission_removed";
+        public static final String function_distribution_permission_set = "function_distribution_permission_set";
+    }
 }

slack-api-client/src/main/java/com/slack/api/audit/response/ActionsResponse.java

@@ -40,5 +40,6 @@ public static class Actions {
         private List<String> appApprovalAutomationRule;
         private List<String> workflowV2;
         private List<String> canvas;
+        private List<String> function;
     }
 }

slack-api-client/src/main/java/com/slack/api/audit/response/SchemasResponse.java

@@ -87,11 +87,14 @@ public static class Channel {
     @Data
     public static class App {
         private String id;
+        private String appId;
         private String name;
         private String isWorkflowApp;
         private String isDistributed;
         private String isDirectoryApproved;
         private String scopes;
+        private String distributionType;
+        private String userIds;
     }
 
     @Data

slack-api-client/src/test/java/test_with_remote_apis/audit/ApiTest.java

@@ -257,6 +257,12 @@ public void getActions_detectingNewOnes() throws IOException, AuditApiException
                 fail("Unknown action detected - " + action);
             }
         }
+        List<String> functionNames = getAllPublicStaticFieldValues(Actions.Function.class);
+        for (String action : actions.getFunction()) {
+            if (!functionNames.contains(action)) {
+                fail("Unknown action detected - " + action);
+            }
+        }
     }
 
     @Test

slack-api-client/src/test/java/test_with_remote_apis/methods_admin_api/AdminApi_workflows_Test.java

@@ -42,6 +42,7 @@ public void adminWorkflowsCollaborators() throws Exception {
             AdminWorkflowsSearchResponse searchResult = methodsAsync.adminWorkflowsSearch(r -> r
                     .limit(30)
             ).get();
+            // 2023-09-26: the server side returns "internal_error"
             assertThat(searchResult.getError(), is(nullValue()));
 
             // TODO: make this more stable
@@ -67,6 +68,7 @@ public void adminWorkflowsPermissions() throws Exception {
             AdminWorkflowsSearchResponse searchResult = methodsAsync.adminWorkflowsSearch(r -> r
                     .limit(30)
             ).get();
+            // 2023-09-26: the server side returns "internal_error"
             assertThat(searchResult.getError(), is(nullValue()));
 
             AdminWorkflowsPermissionsLookupResponse result = methodsAsync.adminWorkflowsPermissionsLookup(r -> r
@@ -80,10 +82,10 @@ public void adminWorkflowsPermissions() throws Exception {
     @Test
     public void adminWorkflowsUnpublish() throws Exception {
         if (orgAdminUserToken != null) {
-            AdminWorkflowsUnpublishResponse searchResult = methodsAsync.adminWorkflowsUnpublish(r -> r
+            AdminWorkflowsUnpublishResponse result = methodsAsync.adminWorkflowsUnpublish(r -> r
                     .workflowIds(Arrays.asList("W111111"))
             ).get();
-            assertThat(searchResult.getError(), is("invalid_arguments"));
+            assertThat(result.getError(), is("invalid_arguments"));
         }
     }
 }