Skip to content

Commit 63e9814

Browse files
committed
Run all the integration tests - 2023-10-20 PT
1 parent ca68693 commit 63e9814

File tree

9 files changed

+42
-7
lines changed

9 files changed

+42
-7
lines changed

json-logs/raw/audit/v1/actions.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,10 @@
166166
"apps_analytics_export_started",
167167
"apps_analytics_export_prepared",
168168
"pref.canvas_retention_changed",
169-
"audit_logs_export_json_started"
169+
"audit_logs_export_json_started",
170+
"pref.atlas_profiles_access_changed",
171+
"pref.atlas_org_charts_access_changed",
172+
"pref.mobile_session_duration_changed"
170173
],
171174
"user": [
172175
"custom_tos_accepted",

json-logs/samples/api/admin.apps.activities.list.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,17 @@
3232
"type": "",
3333
"config": {
3434
"name": "",
35-
"description": ""
35+
"description": "",
36+
"schema": {}
3637
},
3738
"trip_information": {
3839
"user_id": "W00000000",
3940
"channel_id": "C00000000"
4041
}
4142
},
4243
"channel_id": "C00000000",
43-
"bot_user_id": "U00000000"
44+
"bot_user_id": "U00000000",
45+
"inputs": {}
4446
},
4547
"created": 12345,
4648
"trace_id": ""

json-logs/samples/api/admin.users.list.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010
"is_restricted": false,
1111
"is_ultra_restricted": false,
1212
"is_bot": false,
13-
"expiration_ts": 12345
13+
"expiration_ts": 12345,
14+
"username": "",
15+
"full_name": "",
16+
"is_active": false,
17+
"date_created": 12345
1418
}
1519
],
1620
"response_metadata": {

json-logs/samples/api/conversations.list.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,8 @@
6262
""
6363
],
6464
"user": [
65-
"W00000000"
65+
"W00000000",
66+
"U00000000"
6667
]
6768
},
6869
"threads_restricted_to": {

json-logs/samples/api/users.conversations.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@
6262
"posting_restricted_to": {
6363
"type": [
6464
""
65+
],
66+
"user": [
67+
"U00000000"
6568
]
6669
},
6770
"huddles_restricted": false,

slack-api-client/src/main/java/com/slack/api/audit/Actions.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,9 @@ private WorkspaceOrOrg() {
127127
public static final String pref_platform_beta_external_triggers_enabled = "pref.platform_beta_external_triggers_enabled";
128128
public static final String pref_two_factor_prevent_sms_changed = "pref.two_factor_prevent_sms_changed";
129129
public static final String pref_canvas_retention_changed = "pref.canvas_retention_changed";
130+
public static final String pref_atlas_profiles_access_changed = "pref.atlas_profiles_access_changed";
131+
public static final String pref_atlas_org_charts_access_changed = "pref.atlas_org_charts_access_changed";
132+
public static final String pref_mobile_session_duration_changed = "pref.mobile_session_duration_changed";
130133
public static final String manual_export_downloaded = "manual_export_downloaded";
131134
public static final String manual_export_deleted = "manual_export_deleted";
132135
public static final String scheduled_export_downloaded = "scheduled_export_downloaded";

slack-api-client/src/main/java/com/slack/api/methods/response/admin/users/AdminUsersListResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ public class AdminUsersListResponse implements SlackApiTextResponse {
2525
public static class User {
2626
private String id;
2727
private String email;
28+
private String username;
2829
@SerializedName("is_admin")
2930
private boolean admin;
3031
@SerializedName("is_owner")

slack-api-client/src/test/java/util/sample_json_generation/JsonDataRecorder.java

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ private void scanToNormalizeValues(String path, JsonElement parent, String name,
464464
}
465465
}
466466
}
467-
} else if (element.isJsonObject()) {
467+
} else if (element != null && element.isJsonObject()) {
468468
if (name != null && name.equals("file")) {
469469
if (path.startsWith("/audit/v1/schemas") || path.startsWith("/audit/v1/actions")) {
470470
return;
@@ -493,6 +493,20 @@ private void scanToNormalizeValues(String path, JsonElement parent, String name,
493493
}
494494
return;
495495
}
496+
if (name != null && name.equals("inputs") && path.equals("/api/admin.apps.activities.list")) {
497+
JsonObject permissions = element.getAsJsonObject();
498+
try {
499+
// To avoid concurrent modification of the underlying objects
500+
List<String> oldKeys = new ArrayList<>();
501+
permissions.keySet().iterator().forEachRemaining(oldKeys::add);
502+
for (String key : oldKeys) {
503+
permissions.remove(key);
504+
}
505+
506+
} catch (Exception e) {
507+
log.error(e.getMessage(), e);
508+
}
509+
}
496510
if (name != null && name.equals("bookmark")) {
497511
if (path.startsWith("/audit/v1/schemas") || path.startsWith("/audit/v1/actions")) {
498512
return;
@@ -724,7 +738,7 @@ private void scanToNormalizeValues(String path, JsonElement parent, String name,
724738
e.printStackTrace();
725739
}
726740
}
727-
} else if (element.isJsonNull()) {
741+
} else if (element == null || element.isJsonNull()) {
728742
return;
729743
} else if (!parent.isJsonArray() && element.isJsonPrimitive()) {
730744
JsonPrimitive prim = element.getAsJsonPrimitive();

slack-api-model/src/main/java/com/slack/api/model/admin/AppActivity.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import lombok.Data;
44

55
import java.util.List;
6+
import java.util.Map;
67

78
// See https://api.slack.com/methods/admin.apps.activities.list
89
@Data
@@ -39,6 +40,8 @@ public static class Payload {
3940
private List<String> billingReason; // "uses_custom_function" etc.
4041
private Boolean isBillingExcluded;
4142
private Trigger trigger;
43+
// TODO: complete typing for the value
44+
private Map<String, Object> inputs;
4245
}
4346

4447
@Data
@@ -53,6 +56,7 @@ public static class Trigger {
5356
public static class TriggerConfig {
5457
private String name;
5558
private String description;
59+
private Object schema; // TODO: typing
5660
}
5761

5862
@Data

0 commit comments

Comments
 (0)