Skip to content

Commit 9db47c3

Browse files
committed
Run all the integration tests - 2024-08-06 PT
1 parent 71c22e7 commit 9db47c3

File tree

4 files changed

+40
-1
lines changed

4 files changed

+40
-1
lines changed

json-logs/samples/api/apps.manifest.create.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
{
1313
"code": "",
1414
"message": "",
15-
"pointer": ""
15+
"pointer": "",
16+
"related_component": ""
1617
}
1718
],
1819
"app_id": "A00000000",

slack-api-client/src/main/java/com/slack/api/methods/response/apps/manifest/AppsManifestCreateResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,6 @@ public static class Error {
3030
private String code;
3131
private String message;
3232
private String pointer;
33+
private String relatedComponent;
3334
}
3435
}

slack-api-client/src/main/java/com/slack/api/methods/response/apps/manifest/AppsManifestValidateResponse.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,6 @@ public static class Error {
2525
private String code;
2626
private String message;
2727
private String pointer;
28+
private String relatedComponent;
2829
}
2930
}

slack-api-client/src/test/java/test_with_remote_apis/methods/apps_manifest_Test.java

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
import com.slack.api.methods.MethodsClient;
55
import com.slack.api.methods.SlackApiException;
66
import com.slack.api.methods.response.apps.manifest.*;
7+
import com.slack.api.model.event.FunctionExecutedEvent;
8+
import com.slack.api.model.manifest.AppManifest;
79
import com.slack.api.model.manifest.AppManifestParams;
810
import com.slack.api.token_rotation.tooling.ToolingToken;
911
import com.slack.api.token_rotation.tooling.ToolingTokenRotator;
@@ -193,6 +195,31 @@ public void automationPlatform() throws IOException, SlackApiException {
193195
.functions(functions)
194196
.build();
195197

198+
AppManifestParams invalidManifest2 = AppManifestParams.builder()
199+
.metadata(AppManifestParams.Metadata.builder().majorVersion(2).build())
200+
.displayInformation(AppManifestParams.DisplayInformation.builder()
201+
.name("manifest-test-app")
202+
.build())
203+
.settings(AppManifestParams.Settings.builder()
204+
.functionRuntime("remote")
205+
.interactivity(AppManifestParams.Interactivity.builder()
206+
.isEnabled(true)
207+
.build())
208+
// .eventSubscriptions(AppManifestParams.EventSubscriptions.builder()
209+
// .botEvents(Arrays.asList(FunctionExecutedEvent.TYPE_NAME))
210+
// .build())
211+
.socketModeEnabled(true)
212+
.orgDeployEnabled(true)
213+
.build())
214+
.features(AppManifestParams.Features.builder()
215+
.botUser(AppManifestParams.BotUser.builder().displayName("test-bot").build())
216+
.build())
217+
.oauthConfig(AppManifestParams.OAuthConfig.builder()
218+
.scopes(AppManifestParams.Scopes.builder().bot(Arrays.asList("commands")).build())
219+
.build())
220+
.functions(functions)
221+
.build();
222+
196223
AppManifestParams manifest = AppManifestParams.builder()
197224
.metadata(AppManifestParams.Metadata.builder().majorVersion(2).build())
198225
.displayInformation(AppManifestParams.DisplayInformation.builder()
@@ -203,6 +230,9 @@ public void automationPlatform() throws IOException, SlackApiException {
203230
.interactivity(AppManifestParams.Interactivity.builder()
204231
.isEnabled(true)
205232
.build())
233+
.eventSubscriptions(AppManifestParams.EventSubscriptions.builder()
234+
.botEvents(Arrays.asList(FunctionExecutedEvent.TYPE_NAME))
235+
.build())
206236
.socketModeEnabled(true)
207237
.orgDeployEnabled(true)
208238
.build())
@@ -217,11 +247,17 @@ public void automationPlatform() throws IOException, SlackApiException {
217247

218248
AppsManifestValidateResponse validation = client.appsManifestValidate(r -> r.manifest(invalidManifest));
219249
assertThat(validation.getError(), is("invalid_manifest"));
250+
validation = client.appsManifestValidate(r -> r.manifest(invalidManifest2));
251+
assertThat(validation.getError(), is("invalid_manifest"));
220252
validation = client.appsManifestValidate(r -> r.manifest(manifest));
221253
assertThat(validation.getError(), is(nullValue()));
222254

223255
AppsManifestCreateResponse creation = null;
224256
try {
257+
creation = client.appsManifestCreate(r -> r.manifest(invalidManifest));
258+
assertThat(creation.getError(), is("invalid_manifest"));
259+
creation = client.appsManifestCreate(r -> r.manifest(invalidManifest2));
260+
assertThat(creation.getError(), is("invalid_manifest"));
225261
creation = client.appsManifestCreate(r -> r.manifest(manifest));
226262
assertThat(creation.getError(), is(nullValue()));
227263
String appId = creation.getAppId();

0 commit comments

Comments
 (0)