Skip to content

Commit cb5d21e

Browse files
committed
rename helper methods
1 parent 668a091 commit cb5d21e

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

slack-api-client/src/main/java/com/slack/api/methods/RequestFormBuilder.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1614,13 +1614,13 @@ public static FormBody.Builder toForm(ChatPostMessageRequest req) {
16141614
form.add("metadata", json);
16151615
} else {
16161616
EntityMetadata[] entities = metadata.getEntities();
1617-
entities = prepareEntities(metadata.getEntities());
1617+
entities = setEntityMetadataFieldsPropertyForEntities(metadata.getEntities());
16181618
metadata.setEntities(entities);
16191619
String json = GSON.toJson(metadata);
16201620
form.add("metadata", json);
16211621
}
16221622
}
1623-
1623+
16241624
if (req.getBlocksAsString() != null) {
16251625
form.add("blocks", req.getBlocksAsString());
16261626
} else if (req.getBlocks() != null) {
@@ -1740,7 +1740,7 @@ public static FormBody.Builder toForm(ChatUnfurlRequest req) {
17401740
} else if (req.getMetadata() != null) {
17411741
ChatUnfurlRequest.UnfurlMetadata metadata = req.getMetadata();
17421742

1743-
EntityMetadata[] entities = prepareEntities(metadata.getEntities());
1743+
EntityMetadata[] entities = setEntityMetadataFieldsPropertyForEntities(metadata.getEntities());
17441744
metadata.setEntities(entities);
17451745

17461746
String json = GSON.toJson(metadata, ChatUnfurlRequest.UnfurlMetadata.class);
@@ -2072,7 +2072,7 @@ public static FormBody.Builder toForm(EntityPresentDetailsRequest req) {
20722072
setIfNotNull("metadata", req.getRawMetadata(), form);
20732073
} else if (req.getMetadata() != null) {
20742074
EntityMetadata metadata = req.getMetadata();
2075-
metadata = prepareEntityMetadata(metadata);
2075+
metadata = setEntityMetadataFieldsPropertyForEntity(metadata);
20762076
String json = GSON.toJson(metadata, EntityMetadata.class);
20772077
setIfNotNull("metadata", json, form);
20782078
}
@@ -3105,7 +3105,6 @@ public static FormBody.Builder toForm(WorkflowsUpdateStepRequest req) {
31053105
// ----------------------------------------------------------------------------------
31063106
// internal methods
31073107
// ----------------------------------------------------------------------------------
3108-
31093108
private static final String TEXT_WARN_MESSAGE_TEMPLATE = "The top-level `text` argument is missing in the request payload for a {} call - It's a best practice to always provide a `text` argument when posting a message. The `text` is used in places where the content cannot be rendered such as: system push notifications, assistive technology such as screen readers, etc.";
31103109

31113110
private static final String FALLBACK_WARN_MESSAGE_TEMPLATE = "Additionally, the attachment-level `fallback` argument is missing in the request payload for a {} call - To avoid this warning, it is recommended to always provide a top-level `text` argument when posting a message. Alternatively, you can provide an attachment-level `fallback` argument, though this is now considered a legacy field (see https://docs.slack.dev/legacy/legacy-messaging/legacy-secondary-message-attachments#legacy_fields for more details).";
@@ -3183,19 +3182,20 @@ private static <T> String getJsonWithGsonAnonymInnerClassHandling(List<T> tList)
31833182
return GSON_ANONYM_INNER_CLASS_INIT_OUTPUT.equals(json) ? GSON.toJson(new ArrayList<>(tList)) : json;
31843183
}
31853184

3186-
private static EntityMetadata[] prepareEntities(EntityMetadata[] entities) {
3185+
private static EntityMetadata[] setEntityMetadataFieldsPropertyForEntities(EntityMetadata[] entities) {
31873186
List<EntityMetadata> updatedEntities = new ArrayList<EntityMetadata>();
31883187
for (EntityMetadata entity : entities) {
3189-
entity = prepareEntityMetadata(entity);
3188+
entity = setEntityMetadataFieldsPropertyForEntity(entity);
31903189
updatedEntities.add(entity);
31913190
}
3191+
31923192
EntityMetadata[] entityArray = new EntityMetadata[updatedEntities.size()];
31933193
entityArray = updatedEntities.toArray(entityArray);
31943194

31953195
return entityArray;
31963196
}
31973197

3198-
private static EntityMetadata prepareEntityMetadata(EntityMetadata entity) {
3198+
private static EntityMetadata setEntityMetadataFieldsPropertyForEntity(EntityMetadata entity) {
31993199
if (entity.getEntityPayload().getFileFields() != null) {
32003200
String json = GSON.toJson(entity.getEntityPayload().getFileFields(),
32013201
EntityPayload.FileFields.class);
@@ -3224,5 +3224,4 @@ private static EntityMetadata prepareEntityMetadata(EntityMetadata entity) {
32243224

32253225
return entity;
32263226
}
3227-
32283227
}

0 commit comments

Comments
 (0)