fix: json data recorder missing warning field

srtaalej · srtaalej · commit cec73db5e182 · 2025-12-05T14:48:00.000-05:00
diff --git a/json-logs/samples/api/slackLists.access.delete.json b/json-logs/samples/api/slackLists.access.delete.json
@@ -1,12 +1,12 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.access.set.json b/json-logs/samples/api/slackLists.access.set.json
@@ -1,12 +1,12 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.create.json b/json-logs/samples/api/slackLists.create.json
@@ -1,10 +1,6 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
-  "list_id": "",
+  "list_id": "F00000000",
   "list_metadata": {
     "schema": [
       {
@@ -30,8 +26,8 @@
       {
         "key": "",
         "name": "",
-        "type": "",
         "is_primary_column": false,
+        "type": "",
         "id": "",
         "options": {
           "format": "",
@@ -40,9 +36,8 @@
       }
     ]
   },
-  "response_metadata": {
-    "messages": [
-      ""
-    ]
-  }
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.download.get.json b/json-logs/samples/api/slackLists.download.get.json
@@ -1,14 +1,14 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "status": "",
   "download_url": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.download.start.json b/json-logs/samples/api/slackLists.download.start.json
@@ -1,13 +1,13 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "job_id": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.create.json b/json-logs/samples/api/slackLists.items.create.json
@@ -1,9 +1,5 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "item": {
     "id": "",
     "list_id": "",
@@ -40,5 +36,9 @@
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.delete.json b/json-logs/samples/api/slackLists.items.delete.json
@@ -1,7 +1,7 @@
 {
   "ok": false,
-  "warning": "",
   "error": "",
   "needed": "",
-  "provided": ""
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.deleteMultiple.json b/json-logs/samples/api/slackLists.items.deleteMultiple.json
@@ -1,12 +1,12 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.info.json b/json-logs/samples/api/slackLists.items.info.json
@@ -1,9 +1,5 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "list": {
     "id": "",
     "created": 12345,
@@ -183,5 +179,9 @@
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.list.json b/json-logs/samples/api/slackLists.items.list.json
@@ -1,9 +1,5 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "items": [
     {
       "id": "",
@@ -69,5 +65,9 @@
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.items.update.json b/json-logs/samples/api/slackLists.items.update.json
@@ -1,12 +1,12 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/json-logs/samples/api/slackLists.update.json b/json-logs/samples/api/slackLists.update.json
@@ -1,12 +1,12 @@
 {
   "ok": false,
-  "warning": "",
-  "error": "",
-  "needed": "",
-  "provided": "",
   "response_metadata": {
     "messages": [
       ""
     ]
-  }
+  },
+  "error": "",
+  "needed": "",
+  "provided": "",
+  "warning": ""
 }
diff --git a/slack-api-client/src/test/java/util/sample_json_generation/JsonDataRecorder.java b/slack-api-client/src/test/java/util/sample_json_generation/JsonDataRecorder.java
@@ -275,6 +275,7 @@ private static void clearAllElements(JsonArray objects) {
 
     private static final List<String> COMMON_TOP_LEVEL_PROPERTY_NAMES = Arrays.asList(
             "ok",
+            "warning",
             "error",
             "needed",
             "provided"

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,12 @@`
`1`	`1`	`{`
`2`	`2`	`"ok": false,`
`3`		`- "warning": "",`
`4`		`- "error": "",`
`5`		`- "needed": "",`
`6`		`- "provided": "",`
`7`	`3`	`"response_metadata": {`
`8`	`4`	`"messages": [`
`9`	`5`	`""`
`10`	`6`	`]`
`11`		`- }`
	`7`	`+ },`
	`8`	`+ "error": "",`
	`9`	`+ "needed": "",`
	`10`	`+ "provided": "",`
	`11`	`+ "warning": ""`
`12`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,10 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"ok": false,`
`3`		`- "warning": "",`
`4`		`- "error": "",`
`5`		`- "needed": "",`
`6`		`- "provided": "",`
`7`		`- "list_id": "",`
	`3`	`+ "list_id": "F00000000",`
`8`	`4`	`"list_metadata": {`
`9`	`5`	`"schema": [`
`10`	`6`	`{`
`@@ -30,8 +26,8 @@`
`30`	`26`	`{`
`31`	`27`	`"key": "",`
`32`	`28`	`"name": "",`
`33`		`- "type": "",`
`34`	`29`	`"is_primary_column": false,`
	`30`	`+ "type": "",`
`35`	`31`	`"id": "",`
`36`	`32`	`"options": {`
`37`	`33`	`"format": "",`
`@@ -40,9 +36,8 @@`
`40`	`36`	`}`
`41`	`37`	`]`
`42`	`38`	`},`
`43`		`- "response_metadata": {`
`44`		`- "messages": [`
`45`		`- ""`
`46`		`- ]`
`47`		`- }`
	`39`	`+ "error": "",`
	`40`	`+ "needed": "",`
	`41`	`+ "provided": "",`
	`42`	`+ "warning": ""`
`48`	`43`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,13 +1,13 @@`
`1`	`1`	`{`
`2`	`2`	`"ok": false,`
`3`		`- "warning": "",`
`4`		`- "error": "",`
`5`		`- "needed": "",`
`6`		`- "provided": "",`
`7`	`3`	`"job_id": "",`
`8`	`4`	`"response_metadata": {`
`9`	`5`	`"messages": [`
`10`	`6`	`""`
`11`	`7`	`]`
`12`		`- }`
	`8`	`+ },`
	`9`	`+ "error": "",`
	`10`	`+ "needed": "",`
	`11`	`+ "provided": "",`
	`12`	`+ "warning": ""`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"ok": false,`
`3`		`- "warning": "",`
`4`	`3`	`"error": "",`
`5`	`4`	`"needed": "",`
`6`		`- "provided": ""`
	`5`	`+ "provided": "",`
	`6`	`+ "warning": ""`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,5 @@`
`1`	`1`	`{`
`2`	`2`	`"ok": false,`
`3`		`- "warning": "",`
`4`		`- "error": "",`
`5`		`- "needed": "",`
`6`		`- "provided": "",`
`7`	`3`	`"items": [`
`8`	`4`	`{`
`9`	`5`	`"id": "",`
`@@ -69,5 +65,9 @@`
`69`	`65`	`"messages": [`
`70`	`66`	`""`
`71`	`67`	`]`
`72`		`- }`
	`68`	`+ },`
	`69`	`+ "error": "",`
	`70`	`+ "needed": "",`
	`71`	`+ "provided": "",`
	`72`	`+ "warning": ""`
`73`	`73`	`}`