Remove unnecessary code in files.upload v2 method

Author: seratch

slack-api-client/src/main/java/com/slack/api/methods/impl/FilesUploadV2Helper.java

@@ -104,23 +104,8 @@ public FilesUploadV2Response completeUploads(
         if (!response.isOk()) {
             throw underlyingException;
         }
-
-        result.setFiles(new ArrayList<>());
-        for (File file : response.getFiles()) {
-            if (v2Request.isRequestFileInfo()) {
-                FilesInfoResponse fileInfo = this.client.filesInfo(r -> r.token(v2Request.getToken()).file(file.getId()));
-                underlyingException.getFileInfoResponses().add(fileInfo);
-                if (!fileInfo.isOk()) {
-                    throw underlyingException;
-                }
-                result.getFiles().add(fileInfo.getFile());
-            } else {
-                File partialFileObject = File.builder().id(file.getId()).title(file.getTitle()).build();
-                result.getFiles().add(partialFileObject);
-            }
-        }
-
         result.setOk(true);
+        result.setFiles(response.getFiles());
         if (response.getFiles().size() == 1) {
             result.setFile(result.getFiles().get(0));
         }

slack-api-client/src/main/java/com/slack/api/methods/request/files/FilesUploadV2Request.java

@@ -73,7 +73,10 @@ public class FilesUploadV2Request implements SlackApiRequest {
 
     /**
      * Fetches all the file metadata for better v1 compatibility when this property is true.
+     * Note that, starting in v1.34, this flag does not do anything.
+     * The full file metadata is now returned without additional files.info API calls.
      */
+    @Deprecated
     @Builder.Default
     private boolean requestFileInfo = true;
 

slack-api-client/src/test/java/test_with_remote_apis/methods/files_Test.java

@@ -414,43 +414,6 @@ public void createLongTextFile_v2_full_args() throws Exception {
         }
     }
 
-    @Test
-    public void createLongTextFile_v2_no_file_info() throws Exception {
-        com.slack.api.model.File fileObj;
-        {
-            FilesUploadV2Response response = slack.methods(botToken).filesUploadV2(r -> r
-                    .content("test")
-                    .channel(channelId)
-                    .initialComment("initial comment")
-                    .filename("sample.txt")
-                    .title("file title")
-                    .requestFileInfo(false) // Added
-            );
-            assertThat(response.getError(), is(nullValue()));
-            assertThat(response.isOk(), is(true));
-            assertThat(response.getFile().getTitle(), is("file title"));
-            assertThat(response.getFile().getName(), is(nullValue())); // this must be absent
-
-            // I know this is a bit long but this can be necessary for test stability
-            Thread.sleep(10000L);
-            fileObj = slack.methods(botToken).filesInfo(r -> r.file(response.getFile().getId())).getFile();
-
-            assertThat(fileObj.getTitle(), is("file title"));
-            assertThat(fileObj.getName(), is("sample.txt"));
-        }
-        {
-            ChatDeleteResponse response = slack.methods(botToken).chatDelete(r -> r
-                    .channel(channelId)
-                    .ts(fileObj
-                            .getShares()
-                            .getPublicChannels().get(channelId).get(0)
-                            .getTs())
-            );
-            assertThat(response.getError(), is(nullValue()));
-            assertThat(response.isOk(), is(true));
-        }
-    }
-
     @Test
     public void createImageFileAndComments() throws IOException, SlackApiException {
         File file = new File("src/test/resources/seratch.jpg");