fix: add trailing slash to slackApiUrl if none is provided (#2243)

Author: WilliamBergamin

packages/web-api/src/WebClient.spec.ts

@@ -58,6 +58,21 @@ describe('WebClient', () => {
       const client = new WebClient();
       assert.instanceOf(client, WebClient);
     });
+
+    it('should add a trailing slash to slackApiUrl if missing', () => {
+      const client = new WebClient(token, { slackApiUrl: 'https://slack.com/api' });
+      assert.equal(client.slackApiUrl, 'https://slack.com/api/');
+    });
+
+    it('should preserve trailing slash in slackApiUrl if provided', () => {
+      const client = new WebClient(token, { slackApiUrl: 'https://slack.com/api/' });
+      assert.equal(client.slackApiUrl, 'https://slack.com/api/');
+    });
+
+    it('should handle custom domains and add trailing slash', () => {
+      const client = new WebClient(token, { slackApiUrl: 'https://example.com/slack/api' });
+      assert.equal(client.slackApiUrl, 'https://example.com/slack/api/');
+    });
   });
 
   describe('Methods superclass', () => {
@@ -797,6 +812,15 @@ describe('WebClient', () => {
       const client = new WebClient(token, { allowAbsoluteUrls: false });
       await client.apiCall('https://example.com/api/method');
     });
+
+    it('should add a trailing slash to slackApiUrl if missing', async () => {
+      const alternativeUrl = 'http://12.34.56.78/api'; // No trailing slash here
+      nock(alternativeUrl)
+        .post(/api\/method/)
+        .reply(200, { ok: true });
+      const client = new WebClient(token, { slackApiUrl: alternativeUrl });
+      await client.apiCall('method');
+    });
   });
 
   describe('has an option to set request concurrency', () => {

packages/web-api/src/WebClient.ts

@@ -286,6 +286,9 @@ export class WebClient extends Methods {
 
     this.token = token;
     this.slackApiUrl = slackApiUrl;
+    if (!this.slackApiUrl.endsWith('/')) {
+      this.slackApiUrl += '/';
+    }
 
     this.retryConfig = retryConfig;
     this.requestQueue = new pQueue({ concurrency: maxRequestConcurrency });
@@ -311,7 +314,7 @@ export class WebClient extends Methods {
     this.axios = axios.create({
       adapter: adapter ? (config: InternalAxiosRequestConfig) => adapter({ ...config, adapter: undefined }) : undefined,
       timeout,
-      baseURL: slackApiUrl,
+      baseURL: this.slackApiUrl,
       headers: isElectron() ? headers : { 'User-Agent': getUserAgent(), ...headers },
       httpAgent: agent,
       httpsAgent: agent,