Skip to content

Commit 1280242

Browse files
authored
pyee expects an exception when emitting an error
See the following traceback. ``` 10.x.x.x - - [27/Jun/2018 08:13:45] "POST /slack/events HTTP/1.1" 500 - Traceback (most recent call last): File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2309, in __call__ return self.wsgi_app(environ, start_response) File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app response = self.handle_exception(e) File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1741, in handle_exception reraise(exc_type, exc_value, tb) File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise raise value File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app response = self.full_dispatch_request() File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request rv = self.handle_user_exception(e) File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception reraise(exc_type, exc_value, tb) File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise raise value File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request rv = self.dispatch_request() File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/usr/local/lib/python3.6/site-packages/slackeventsapi/server.py", line 63, in event self.emitter.emit('error', 'invalid verification token') File "/usr/local/lib/python3.6/site-packages/pyee/__init__.py", line 178, in emit raise args[0] TypeError: exceptions must derive from BaseException ```
1 parent 9104372 commit 1280242

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

slackeventsapi/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def event():
6060
# Verify the request token
6161
request_token = event_data.get("token")
6262
if self.verification_token != request_token:
63-
self.emitter.emit('error', 'invalid verification token')
63+
self.emitter.emit('error', Exception('invalid verification token''))
6464
return make_response("Request contains invalid Slack verification token", 403)
6565

6666
# Parse the Event payload and emit the event to the event listener

0 commit comments

Comments
 (0)