Improve #1084 by removing globally mutable lists (#1092)

Author: seratch

slack_sdk/audit_logs/v1/async_client.py

@@ -55,7 +55,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[AsyncRetryHandler] = async_default_handlers,
+        retry_handlers: List[AsyncRetryHandler] = async_default_handlers(),
     ):
         """API client for Audit Logs API
         See https://api.slack.com/admins/audit-logs for more details

slack_sdk/audit_logs/v1/client.py

@@ -50,7 +50,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[RetryHandler] = default_retry_handlers,
+        retry_handlers: List[RetryHandler] = default_retry_handlers(),
     ):
         """API client for Audit Logs API
         See https://api.slack.com/admins/audit-logs for more details

slack_sdk/http_retry/__init__.py

@@ -1,3 +1,5 @@
+from typing import List
+
 from .handler import RetryHandler  # noqa
 from .builtin_handlers import (
     ConnectionErrorRetryHandler,  # noqa
@@ -16,11 +18,13 @@
 connect_error_retry_handler = ConnectionErrorRetryHandler()  # noqa
 rate_limit_error_retry_handler = RateLimitErrorRetryHandler()  # noqa
 
-default_retry_handlers = [  # noqa
-    connect_error_retry_handler,  # noqa
-]  # noqa
 
-all_builtin_retry_handlers = [  # noqa
-    connect_error_retry_handler,  # noqa
-    rate_limit_error_retry_handler,  # noqa
-]  # noqa
+def default_retry_handlers() -> List[RetryHandler]:
+    return [connect_error_retry_handler]
+
+
+def all_builtin_retry_handlers() -> List[RetryHandler]:
+    return [
+        connect_error_retry_handler,
+        rate_limit_error_retry_handler,
+    ]

slack_sdk/http_retry/builtin_async_handlers.py

@@ -87,4 +87,5 @@ async def prepare_for_next_attempt_async(
         await asyncio.sleep(duration)
 
 
-async_default_handlers = [AsyncConnectionErrorRetryHandler()]
+def async_default_handlers() -> List[AsyncRetryHandler]:
+    return [AsyncConnectionErrorRetryHandler()]

slack_sdk/scim/v1/async_client.py

@@ -70,7 +70,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[AsyncRetryHandler] = async_default_handlers,
+        retry_handlers: List[AsyncRetryHandler] = async_default_handlers(),
     ):
         """API client for SCIM API
         See https://api.slack.com/scim for more details

slack_sdk/scim/v1/client.py

@@ -72,7 +72,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[RetryHandler] = default_retry_handlers,
+        retry_handlers: List[RetryHandler] = default_retry_handlers(),
     ):
         """API client for SCIM API
         See https://api.slack.com/scim for more details

slack_sdk/web/async_base_client.py

@@ -41,7 +41,7 @@ def __init__(
         # for Org-Wide App installation
         team_id: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[RetryHandler] = async_default_handlers,
+        retry_handlers: List[RetryHandler] = async_default_handlers(),
     ):
         self.token = None if token is None else token.strip()
         self.base_url = base_url

slack_sdk/web/base_client.py

@@ -54,7 +54,7 @@ def __init__(
         # for Org-Wide App installation
         team_id: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[RetryHandler] = default_retry_handlers,
+        retry_handlers: List[RetryHandler] = default_retry_handlers(),
     ):
         self.token = None if token is None else token.strip()
         self.base_url = base_url

slack_sdk/webhook/async_client.py

@@ -49,7 +49,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[AsyncRetryHandler] = async_default_handlers,
+        retry_handlers: List[AsyncRetryHandler] = async_default_handlers(),
     ):
         """API client for Incoming Webhooks and `response_url`
 

slack_sdk/webhook/client.py

@@ -44,7 +44,7 @@ def __init__(
         user_agent_prefix: Optional[str] = None,
         user_agent_suffix: Optional[str] = None,
         logger: Optional[logging.Logger] = None,
-        retry_handlers: List[RetryHandler] = default_retry_handlers,
+        retry_handlers: List[RetryHandler] = default_retry_handlers(),
     ):
         """API client for Incoming Webhooks and `response_url`