Apply additional changes to #850

Author: seratch

slack_sdk/web/async_client.py

@@ -2288,15 +2288,20 @@ async def views_push(
                 e.g. '12345.98765.abcd2358fdea'
             view (dict or View): The view payload.
         """
-        kwargs.update({"trigger_id": trigger_id})
+        kwargs.update({"trigger_id": trigger_id, "view": view})
         if isinstance(view, View):
             kwargs.update({"view": view.to_dict()})
         else:
             kwargs.update({"view": view})
         return await self.api_call("views.push", json=kwargs)
 
     async def views_update(
-        self, *, view: Union[dict, View], external_id: str = None, view_id: str = None, **kwargs
+        self,
+        *,
+        view: Union[dict, View],
+        external_id: str = None,
+        view_id: str = None,
+        **kwargs
     ) -> AsyncSlackResponse:
         """Update an existing view.
 

slack_sdk/web/client.py

@@ -2138,7 +2138,9 @@ def views_open(
             kwargs.update({"view": view})
         return self.api_call("views.open", json=kwargs)
 
-    def views_push(self, *, trigger_id: str, view: Union[dict, View], **kwargs) -> SlackResponse:
+    def views_push(
+        self, *, trigger_id: str, view: Union[dict, View], **kwargs
+    ) -> SlackResponse:
         """Push a view onto the stack of a root view.
 
         Push a new view onto the existing view stack by passing a view
@@ -2161,7 +2163,12 @@ def views_push(self, *, trigger_id: str, view: Union[dict, View], **kwargs) -> S
         return self.api_call("views.push", json=kwargs)
 
     def views_update(
-        self, *, view: Union[dict, View], external_id: str = None, view_id: str = None, **kwargs
+        self,
+        *,
+        view: Union[dict, View],
+        external_id: str = None,
+        view_id: str = None,
+        **kwargs
     ) -> SlackResponse:
         """Update an existing view.
 
@@ -2193,7 +2200,9 @@ def views_update(
 
         return self.api_call("views.update", json=kwargs)
 
-    def views_publish(self, *, user_id: str, view: Union[dict, View], **kwargs) -> SlackResponse:
+    def views_publish(
+        self, *, user_id: str, view: Union[dict, View], **kwargs
+    ) -> SlackResponse:
         """Publish a static view for a User.
         Create or update the view that comprises an
         app's Home tab (https://api.slack.com/surfaces/tabs)

slack_sdk/web/legacy_client.py

@@ -2276,7 +2276,7 @@ def views_open(
         return self.api_call("views.open", json=kwargs)
 
     def views_push(
-        self, *, trigger_id: str, view: dict, **kwargs
+        self, *, trigger_id: str, view: Union[dict, View], **kwargs
     ) -> Union[Future, SlackResponse]:
         """Push a view onto the stack of a root view.
 
@@ -2290,13 +2290,22 @@ def views_push(
         Args:
             trigger_id (str): Exchange a trigger to post to the user.
                 e.g. '12345.98765.abcd2358fdea'
-            view (dict): The view payload.
+            view (dict or View): The view payload.
         """
         kwargs.update({"trigger_id": trigger_id, "view": view})
+        if isinstance(view, View):
+            kwargs.update({"view": view.to_dict()})
+        else:
+            kwargs.update({"view": view})
         return self.api_call("views.push", json=kwargs)
 
     def views_update(
-        self, *, view: dict, external_id: str = None, view_id: str = None, **kwargs
+        self,
+        *,
+        view: Union[dict, View],
+        external_id: str = None,
+        view_id: str = None,
+        **kwargs
     ) -> Union[Future, SlackResponse]:
         """Update an existing view.
 
@@ -2307,15 +2316,18 @@ def views_update(
         to learn more about updating views and avoiding race conditions with the hash argument.
 
         Args:
-            view (dict): The view payload.
+            view (dict or View): The view payload.
             external_id (str): A unique identifier of the view set by the developer.
                 e.g. 'bmarley_view2'
             view_id (str): A unique identifier of the view to be updated.
                 e.g. 'VMM512F2U'
         Raises:
             SlackRequestError: Either view_id or external_id is required.
         """
-        kwargs.update({"view": view})
+        if isinstance(view, View):
+            kwargs.update({"view": view.to_dict()})
+        else:
+            kwargs.update({"view": view})
         if external_id:
             kwargs.update({"external_id": external_id})
         elif view_id:
@@ -2326,7 +2338,7 @@ def views_update(
         return self.api_call("views.update", json=kwargs)
 
     def views_publish(
-        self, *, user_id: str, view: dict, **kwargs
+        self, *, user_id: str, view: Union[dict, View], **kwargs
     ) -> Union[Future, SlackResponse]:
         """Publish a static view for a User.
         Create or update the view that comprises an
@@ -2335,9 +2347,13 @@ def views_publish(
         Args:
             user_id (str): id of the user you want publish a view to.
                 e.g. 'U0BPQUNTA'
-            view (dict): The view payload.
+            view (dict or View): The view payload.
         """
-        kwargs.update({"user_id": user_id, "view": view})
+        kwargs.update({"user_id": user_id})
+        if isinstance(view, View):
+            kwargs.update({"view": view.to_dict()})
+        else:
+            kwargs.update({"view": view})
         return self.api_call("views.publish", json=kwargs)
 
     def workflows_stepCompleted(