Skip to content

Commit 4b7f996

Browse files
authored
Index users by ID instead of name (#156)
* Index users by ID instead of name
1 parent 6ab243f commit 4b7f996

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

slackclient/_server.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,8 @@ def websocket_safe_read(self):
151151
raise
152152
return data.rstrip()
153153

154-
def attach_user(self, name, channel_id, real_name, tz):
155-
self.users.update({name: User(self, name, channel_id, real_name, tz)})
154+
def attach_user(self, name, user_id, real_name, tz):
155+
self.users.update({user_id: User(self, name, user_id, real_name, tz)})
156156

157157
def attach_channel(self, name, channel_id, members=None):
158158
if members is None:

slackclient/_util.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ def find(self, name):
1919

2020
class SearchDict(dict):
2121
def find(self, search_string):
22-
# Find the user by name
22+
# Find the user by ID
2323
user = self.get(search_string)
2424
if user:
2525
return user
2626
else:
27-
# If the user can't be found by name, try searching by ID
28-
for name, user in self.items():
29-
if str(user.id) == search_string:
27+
# If the user can't be found by ID, try searching by name
28+
for id, user in self.items():
29+
if str(user.name) == search_string:
3030
return user

0 commit comments

Comments
 (0)