Fix #1292 files_upload_v2 does not work with io.BytesIO file parameters (#1294)

Author: seratch

integration_tests/web/test_files_upload_v2.py

@@ -1,6 +1,7 @@
 import logging
 import os
 import unittest
+from io import BytesIO
 
 import pytest
 
@@ -44,12 +45,12 @@ def test_uploading_text_files(self):
         )
         self.assertIsNotNone(upload)
 
-    def test_uploading_text_files_legacy(self):
-        client = self.legacy_client
-        file = __file__
+    def test_uploading_bytes_io(self):
+        client = self.sync_client
         upload = client.files_upload_v2(
             channels=self.channel_id,
-            file=file,
+            file=BytesIO(bytearray("This is a test!", "utf-8")),
+            filename="test.txt",
             title="Test code",
         )
         self.assertIsNotNone(upload)

slack_sdk/web/internal_utils.py

@@ -7,6 +7,7 @@
 import warnings
 from asyncio import Future
 from http.client import HTTPResponse
+from io import IOBase
 from ssl import SSLContext
 from typing import Any, Dict, Optional, Sequence, Union
 from urllib.parse import urljoin
@@ -314,8 +315,14 @@ def _to_v2_file_upload_item(upload_file: Dict[str, Any]) -> Dict[str, Optional[A
         if isinstance(file, str):  # filepath
             with open(file.encode("utf-8", "ignore"), "rb") as readable:
                 data = readable.read()
-        else:
+        elif isinstance(file, bytes):
             data = file
+        elif isinstance(file, IOBase):
+            data = file.read()
+            if isinstance(data, str):
+                data = data.encode()
+        else:
+            raise SlackRequestError("file parameter must be any of filepath, bytes, and io.IOBase")
     elif content is not None:
         if isinstance(content, str):
             data = content.encode("utf-8")