Skip to content

Commit 862796c

Browse files
fix: update release instructions in maintainers guide (#1507)
* Small fix * hmmm * Update maintainers_guide.md * fix white space
1 parent 41cbaa4 commit 862796c

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/maintainers_guide.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ $ ./scripts/generate_api_docs.sh
139139

140140
- Use the latest stable Python runtime
141141
- `python -m venv env`
142-
- `python setup.py upload`
142+
- `./scripts/deploy_to_prod_pypi_org.sh`
143143
- Create a GitHub Release. You will select the commit with updated version number (e.g. `version 2.5.0`) to associate with the tag, and name the tag after this version (e.g. `v2.5.0`). This will also serve as a Changelog for the project. Add a description of changes to the Release. Mention Issue and PR #'s and @-mention contributors.
144144

145145
```markdown
@@ -152,9 +152,13 @@ $ ./scripts/generate_api_docs.sh
152152

153153
**All Changes**
154154

155-
https://github.com/slackapi/python-slack-sdk/compare/{the previous release version tag}...{the release version tag}
155+
* All issues/pull requests: https://github.com/slackapi/python-slack-sdk/milestone/{milestone for the release}
156+
* All changes: https://github.com/slackapi/python-slack-sdk/compare/{the previous release version tag}...{the release version tag}
156157
```
157158

159+
- Close the milestone relating to the Release
160+
- Create the next patch version Milestone. To be used by the following release.
161+
158162
3. (Slack Internal) Communicate the release internally
159163

160164
- Include a link to the GitHub release

0 commit comments

Comments
 (0)