Add missing properties in Audit Logs details data class (#1113)

Author: seratch

slack_sdk/audit_logs/v1/logs.py

@@ -86,6 +86,22 @@ def __init__(
         self.unknown_fields = kwargs
 
 
+class RetentionPolicy:
+    type: Optional[str]
+    duration_days: Optional[int]
+
+    def __init__(
+        self,
+        *,
+        type: Optional[str] = None,
+        duration_days: Optional[int] = None,
+        **kwargs,
+    ) -> None:
+        self.type = type
+        self.duration_days = duration_days
+        self.unknown_fields = kwargs
+
+
 class Details:
     name: Optional[str]
     new_value: Optional[Union[str, List[str], Dict[str, Any]]]
@@ -140,6 +156,8 @@ class Details:
     added_team_id: Optional[str]
     unknown_fields: Dict[str, Any]
     is_token_rotation_enabled_app: Optional[bool]
+    old_retention_policy: Optional[RetentionPolicy]
+    new_retention_policy: Optional[RetentionPolicy]
 
     def __init__(
         self,
@@ -153,8 +171,8 @@ def __init__(
         non_sso_only: Optional[bool] = None,
         type: Optional[str] = None,
         is_workflow: Optional[bool] = None,
-        inviter: Optional[User] = None,
-        kicker: Optional[User] = None,
+        inviter: Optional[Union[Dict[str, Any], User]] = None,
+        kicker: Optional[Union[Dict[str, Any], User]] = None,
         shared_to: Optional[str] = None,
         reason: Optional[str] = None,
         origin_team: Optional[str] = None,
@@ -196,6 +214,8 @@ def __init__(
         channel_id: Optional[str] = None,
         added_team_id: Optional[str] = None,
         is_token_rotation_enabled_app: Optional[bool] = None,
+        old_retention_policy: Optional[Union[Dict[str, Any], RetentionPolicy]] = None,
+        new_retention_policy: Optional[Union[Dict[str, Any], RetentionPolicy]] = None,
         **kwargs,
     ) -> None:
         self.name = name
@@ -207,8 +227,8 @@ def __init__(
         self.non_sso_only = non_sso_only
         self.type = type
         self.is_workflow = is_workflow
-        self.inviter = inviter
-        self.kicker = kicker
+        self.inviter = inviter if isinstance(inviter, User) else User(**inviter)
+        self.kicker = kicker if isinstance(kicker, User) else User(**kicker)
         self.shared_to = shared_to
         self.reason = reason
         self.origin_team = origin_team
@@ -251,6 +271,16 @@ def __init__(
         self.channel_id = channel_id
         self.added_team_id = added_team_id
         self.is_token_rotation_enabled_app = is_token_rotation_enabled_app
+        self.old_retention_policy = (
+            old_retention_policy
+            if isinstance(old_retention_policy, RetentionPolicy)
+            else RetentionPolicy(**old_retention_policy)
+        )
+        self.new_retention_policy = (
+            new_retention_policy
+            if isinstance(new_retention_policy, RetentionPolicy)
+            else RetentionPolicy(**new_retention_policy)
+        )
 
 
 class App:

tests/slack_sdk/audit_logs/test_response.py

@@ -126,6 +126,11 @@ def test_logs_complete(self):
             [],
             f"found: {entry.actor.unknown_fields.keys()}",
         )
+        self.assertEqual(entry.details.is_token_rotation_enabled_app, True)
+        self.assertEqual(entry.details.inviter.id, "inviter_id")
+        self.assertEqual(entry.details.kicker.id, "kicker_id")
+        self.assertEqual(entry.details.old_retention_policy.type, "old")
+        self.assertEqual(entry.details.new_retention_policy.type, "new")
 
 
 logs_response_data = """{
@@ -242,27 +247,13 @@ def test_logs_complete(self):
           ""
         ],
         "inviter": {
-          "type": "",
-          "user": {
-            "id": "",
-            "name": "",
-            "email": "",
-            "team": ""
-          },
-          "id": "",
+          "id": "inviter_id",
           "name": "",
           "email": "",
           "team": ""
         },
         "kicker": {
-          "type": "",
-          "user": {
-            "id": "",
-            "name": "",
-            "email": "",
-            "team": ""
-          },
-          "id": "",
+          "id": "kicker_id",
           "name": "",
           "email": "",
           "team": ""
@@ -331,7 +322,16 @@ def test_logs_complete(self):
         "external_user_id": "",
         "external_user_email": "",
         "channel_id": "",
-        "added_team_id": ""
+        "added_team_id": "",
+        "is_token_rotation_enabled_app": true,
+        "old_retention_policy": {
+          "type": "old",
+          "duration_days": 111
+        },
+        "new_retention_policy": {
+          "type": "new",
+          "duration_days": 222
+        }
       }
     }
   ]