Skip to content

Commit 9aaea27

Browse files
authored
Fix #1342 files_upload_v2 fails to share files in a channel (#1343)
1 parent 66e8359 commit 9aaea27

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

integration_tests/samples/basic_usage/uploading_files.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@
1414
channels = ",".join(["#random"])
1515
filepath = "./tmp.txt"
1616
response = client.files_upload(channels=channels, file=filepath)
17+
response = client.files_upload_v2(channel=response.get("file").get("channels")[0], file=filepath)

slack_sdk/web/async_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3152,9 +3152,10 @@ async def files_upload_v2(
31523152
channel_to_share = channels[0]
31533153
completion = await self.files_completeUploadExternal(
31543154
files=[{"id": f["file_id"], "title": f["title"]} for f in files],
3155-
channel=channel_to_share,
3155+
channel_id=channel_to_share,
31563156
initial_comment=initial_comment,
31573157
thread_ts=thread_ts,
3158+
token=kwargs.get("token"),
31583159
**kwargs,
31593160
)
31603161
if request_file_info is True:

slack_sdk/web/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3143,9 +3143,10 @@ def files_upload_v2(
31433143
channel_to_share = channels[0]
31443144
completion = self.files_completeUploadExternal(
31453145
files=[{"id": f["file_id"], "title": f["title"]} for f in files],
3146-
channel=channel_to_share,
3146+
channel_id=channel_to_share,
31473147
initial_comment=initial_comment,
31483148
thread_ts=thread_ts,
3149+
token=kwargs.get("token"),
31493150
**kwargs,
31503151
)
31513152
if request_file_info is True:

slack_sdk/web/legacy_client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3154,9 +3154,10 @@ def files_upload_v2(
31543154
channel_to_share = channels[0]
31553155
completion = self.files_completeUploadExternal(
31563156
files=[{"id": f["file_id"], "title": f["title"]} for f in files],
3157-
channel=channel_to_share,
3157+
channel_id=channel_to_share,
31583158
initial_comment=initial_comment,
31593159
thread_ts=thread_ts,
3160+
token=kwargs.get("token"),
31603161
**kwargs,
31613162
)
31623163
if request_file_info is True:

0 commit comments

Comments
 (0)