Fix incorrectly encoded Web API field types (#279)

* Fixed Web API post field types

* Added bool and int to type check

Author: Roach

slackclient/slackrequest.py

@@ -1,6 +1,6 @@
 import requests
-import six  # noqa: F401
-
+import json
+import six
 import sys
 import platform
 from .version import __version__
@@ -60,10 +60,11 @@ def do(self, token, request="?", post_data=None, domain="slack.com", timeout=Non
 
         url = 'https://{0}/api/{1}'.format(domain, request)
 
-        # Override token header if token is passed in form params
+        # Override token header if `token` is passed in post_data
         if post_data is not None and "token" in post_data:
             token = post_data['token']
 
+        # Set user-agent and auth headers
         headers = {
             'user-agent': self.get_user_agent(),
             'Authorization': 'Bearer {}'.format(token)
@@ -74,18 +75,26 @@ def do(self, token, request="?", post_data=None, domain="slack.com", timeout=Non
         # use the 'file' argument to point to a File ID.
         post_data = post_data or {}
 
-        # Check for plural fields and convert them to comma-separated strings if needed
-        for field in {'channels', 'users', 'types'} & set(post_data.keys()):
-            if isinstance(post_data[field], list):
-                post_data[field] = ",".join(post_data[field])
-
         # Move singular file objects into `files`
         upload_requests = ['files.upload']
 
+        # Move file content into requests' `files` param
         files = None
         if request in upload_requests:
             files = {'file': post_data.pop('file')} if 'file' in post_data else None
 
+        # Check for plural fields and convert them to comma-separated strings if needed
+        for field in {'channels', 'users', 'types'} & set(post_data.keys()):
+            if isinstance(post_data[field], list):
+                post_data[field] = ",".join(post_data[field])
+
+        # Convert any params which aren't integer, string or bool to JSON
+        # Example: `attachments` is a dict
+        for k, v in six.iteritems(post_data):
+            if not isinstance(v, (six.string_types, six.integer_types, bool)):
+                post_data[k] = json.dumps(v)
+
+        # Submit the request
         return requests.post(
             url,
             headers=headers,

tests/test_slackrequest.py

@@ -41,6 +41,7 @@ def test_auth_header(mocker):
 
     assert "Bearer xoxb-123" in kwargs['headers']['Authorization']
 
+
 def test_token_override(mocker):
     requests = mocker.patch('slackclient.slackrequest.requests')
     request = SlackRequest()
@@ -111,5 +112,4 @@ def test_post_attachements(mocker):
 
     assert requests.post.call_count == 1
     assert 'https://slack.com/api/chat.postMessage' == args[0]
-    assert {'attachments': [{'title': 'hello'}]} == kwargs['data']
-    assert kwargs['files'] is None
+    assert isinstance(kwargs["data"]["attachments"], str)