Fix #1200 Model to_dict doesn't handle tuple sequences (#1206)

Co-authored-by: Fil Maj <[email protected]>

Author: seratch

slack_sdk/models/basic_objects.py

@@ -1,6 +1,6 @@
 from abc import ABCMeta, abstractmethod
 from functools import wraps
-from typing import Callable, Iterable, Set, Union, Any
+from typing import Callable, Iterable, Set, Union, Any, Tuple
 
 from slack_sdk.errors import SlackObjectFormationError
 
@@ -38,9 +38,9 @@ def get_non_null_attributes(self) -> dict:
         """
 
         def to_dict_compatible(
-            value: Union[dict, list, object]
+            value: Union[dict, list, object, Tuple]
         ) -> Union[dict, list, Any]:
-            if isinstance(value, list):  # skipcq: PYL-R1705
+            if isinstance(value, (list, Tuple)):  # skipcq: PYL-R1705
                 return [to_dict_compatible(v) for v in value]
             else:
                 to_dict = getattr(value, "to_dict", None)

tests/slack_sdk/models/test_elements.py

@@ -641,6 +641,28 @@ def test_focus_on_load(self):
         }
         self.assertDictEqual(input, StaticSelectElement(**input).to_dict())
 
+    def test_lists_and_tuples_serialize_to_dict_equally(self):
+        expected = {
+            "options": [
+                {
+                    "text": {"emoji": True, "text": "X", "type": "plain_text"},
+                    "value": "x",
+                }
+            ],
+            "type": "static_select",
+        }
+        option = Option(value="x", text="X")
+        # List
+        self.assertDictEqual(
+            expected,
+            StaticSelectElement(options=[option]).to_dict(),
+        )
+        # Tuple (this pattern used to be failing)
+        self.assertDictEqual(
+            expected,
+            StaticSelectElement(options=(option,)).to_dict(),
+        )
+
 
 # -------------------------------------------------
 # External Data Source Select