Skip to content

Commit b22ac3c

Browse files
committed
Correct the behavior change of files.upload API method
Refer to integration_tests/web/test_issue_672.py
1 parent e8ab4ad commit b22ac3c

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

slack_sdk/web/async_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2905,7 +2905,7 @@ async def files_upload(
29052905
}
29062906
)
29072907
if file:
2908-
if "filename" not in kwargs and isinstance(file, str):
2908+
if kwargs.get("filename") is None and isinstance(file, str):
29092909
# use the local filename if filename is missing
29102910
if kwargs.get("filename") is None:
29112911
kwargs["filename"] = file.split(os.path.sep)[-1]

slack_sdk/web/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2848,7 +2848,7 @@ def files_upload(
28482848
}
28492849
)
28502850
if file:
2851-
if "filename" not in kwargs and isinstance(file, str):
2851+
if kwargs.get("filename") is None and isinstance(file, str):
28522852
# use the local filename if filename is missing
28532853
if kwargs.get("filename") is None:
28542854
kwargs["filename"] = file.split(os.path.sep)[-1]

slack_sdk/web/legacy_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2859,7 +2859,7 @@ def files_upload(
28592859
}
28602860
)
28612861
if file:
2862-
if "filename" not in kwargs and isinstance(file, str):
2862+
if kwargs.get("filename") is None and isinstance(file, str):
28632863
# use the local filename if filename is missing
28642864
if kwargs.get("filename") is None:
28652865
kwargs["filename"] = file.split(os.path.sep)[-1]

0 commit comments

Comments
 (0)