improving tests and _get_url()

Author: HTSagara

slack_sdk/web/internal_utils.py

@@ -67,8 +67,8 @@ def _get_url(base_url: str, api_method: str) -> str:
         The absolute API URL.
             e.g. 'https://slack.com/api/chat.postMessage'
     """
-    if base_url.endswith("/") and api_method.startswith("/"):
-        api_method = api_method.lstrip("/")
+    # Ensure no leading slash in api_method to prevent double slashes
+    api_method = api_method.lstrip("/")
     return urljoin(base_url, api_method)
 
 

tests/slack_sdk/web/test_internal_utils.py

@@ -119,14 +119,6 @@ def test_get_url_prevent_double_slash(self):
             "Should correctly handle and remove double slashes between base_url and api_method",
         )
 
-        # Test case: Handle base_url without trailing slash
-        api_url = _get_url("https://slack.com/api", "chat.postMessage")
-        self.assertEqual(
-            api_url,
-            "https://slack.com/chat.postMessage",
-            "Should correctly handle base_url without a trailing slash",
-        )
-
         # Test case: Handle api_method without leading slash
         api_url = _get_url("https://slack.com/api/", "chat.postMessage")
         self.assertEqual(
@@ -136,9 +128,9 @@ def test_get_url_prevent_double_slash(self):
         )
 
         # Test case: Both inputs are clean
-        api_url = _get_url("https://slack.com/api", "/chat.postMessage")
+        api_url = _get_url("https://slack.com/api/", "chat.postMessage")
         self.assertEqual(
             api_url,
-            "https://slack.com/chat.postMessage",
+            "https://slack.com/api/chat.postMessage",
             "Should correctly combine base_url and api_method with clean inputs",
         )