Add support for mypy

Author: WilliamBergamin

pyproject.toml

@@ -73,6 +73,6 @@ asyncio_mode = "auto"
 
 [tool.mypy]
 files = "slack_sdk/"
+exclude = ["slack_sdk/scim", "slack_sdk/rtm"]
 force_union_syntax = true
 warn_unused_ignores = true
-exclude = ["slack_sdk/scim/*", "slack_sdk/rtm/*"]

slack_sdk/audit_logs/v1/async_client.py

@@ -226,7 +226,7 @@ async def _perform_http_request(
         headers: Dict[str, str],
     ) -> AuditLogsResponse:
         if body_params is not None:
-            body_params = json.dumps(body_params)
+            body_params = json.dumps(body_params)  # type: ignore[assignment]
         headers["Content-Type"] = "application/json;charset=utf-8"
 
         session: Optional[ClientSession] = None
@@ -279,7 +279,7 @@ async def _perform_http_request(
                     )
 
                 try:
-                    async with session.request(http_verb, url, **request_kwargs) as res:  # type: ignore[arg-type]
+                    async with session.request(http_verb, url, **request_kwargs) as res:  # type: ignore[arg-type, union-attr]
                         try:
                             response_body = await res.text()
                             retry_response = RetryHttpResponse(
@@ -352,7 +352,7 @@ async def _perform_http_request(
 
             if resp is not None:
                 return resp
-            raise last_error
+            raise last_error  # type: ignore[misc]
 
         finally:
             if not use_running_session:

slack_sdk/audit_logs/v1/client.py

@@ -218,7 +218,7 @@ def _perform_http_request(
         headers: Dict[str, str],
     ) -> AuditLogsResponse:
         if body is not None:
-            body = json.dumps(body)
+            body = json.dumps(body)  # type: ignore[assignment]
         headers["Content-Type"] = "application/json;charset=utf-8"
 
         if self.logger.level <= logging.DEBUG:
@@ -230,7 +230,7 @@ def _perform_http_request(
         req = Request(
             method=http_verb,
             url=url,
-            data=body.encode("utf-8") if body is not None else None,
+            data=body.encode("utf-8") if body is not None else None,  # type: ignore[attr-defined]
             headers=headers,
         )
         resp = None
@@ -328,7 +328,7 @@ def _perform_http_request(
 
         if resp is not None:
             return resp
-        raise last_error
+        raise last_error  # type: ignore[misc]
 
     def _perform_http_request_internal(self, url: str, req: Request) -> AuditLogsResponse:
         opener: Optional[OpenerDirector] = None

slack_sdk/audit_logs/v1/logs.py

@@ -822,7 +822,7 @@ def __init__(
         self.rules_checked = None
         if rules_checked is not None:
             self.rules_checked = []
-            for a in rules_checked:
+            for a in rules_checked:  # type: ignore[assignment]
                 if isinstance(a, dict):
                     self.rules_checked.append(AAARule(**a))  # type: ignore[arg-type]
                 else:
@@ -1235,7 +1235,7 @@ def __init__(
         provided: Optional[str] = None,
         **kwargs,
     ) -> None:
-        self.entries = [Entry(**e) if isinstance(e, dict) else e for e in entries]
+        self.entries = [Entry(**e) if isinstance(e, dict) else e for e in entries]  # type: ignore[union-attr]
         self.response_metadata = (
             ResponseMetadata(**response_metadata) if isinstance(response_metadata, dict) else response_metadata
         )

slack_sdk/audit_logs/v1/response.py

@@ -13,7 +13,7 @@ class AuditLogsResponse:
     body: Optional[Dict[str, Any]]
     typed_body: Optional[LogsResponse]
 
-    @property
+    @property  # type:ignore[no-redef]
     def typed_body(self) -> Optional[LogsResponse]:
         if self.body is None:
             return None

slack_sdk/http_retry/builtin_async_handlers.py

@@ -68,7 +68,7 @@ async def prepare_for_next_attempt_async(
         error: Optional[Exception] = None,
     ) -> None:
         if response is None:
-            raise error
+            raise error  # type: ignore[misc]
 
         state.next_attempt_requested = True
         retry_after_header_name: Optional[str] = None
@@ -79,9 +79,9 @@ async def prepare_for_next_attempt_async(
         duration = 1
         if retry_after_header_name is None:
             # This situation usually does not arise. Just in case.
-            duration += random.random()
+            duration += random.random()  # type: ignore[assignment]
         else:
-            duration = int(response.headers.get(retry_after_header_name)[0]) + random.random()
+            duration = int(response.headers.get(retry_after_header_name)[0]) + random.random()  # type: ignore[assignment, index]
         await asyncio.sleep(duration)
         state.increment_current_attempt()
 

slack_sdk/http_retry/builtin_handlers.py

@@ -71,7 +71,7 @@ def prepare_for_next_attempt(
         error: Optional[Exception] = None,
     ) -> None:
         if response is None:
-            raise error
+            raise error  # type: ignore[misc]
 
         state.next_attempt_requested = True
         retry_after_header_name: Optional[str] = None
@@ -82,9 +82,9 @@ def prepare_for_next_attempt(
         duration = 1
         if retry_after_header_name is None:
             # This situation usually does not arise. Just in case.
-            duration += random.random()
+            duration += random.random()  # type: ignore[assignment]
         else:
-            duration = int(response.headers.get(retry_after_header_name)[0]) + random.random()
+            duration = int(response.headers.get(retry_after_header_name)[0]) + random.random()  # type: ignore[index, assignment]
         time.sleep(duration)
         state.increment_current_attempt()
 

slack_sdk/models/__init__.py

@@ -12,7 +12,7 @@
 # NOTE: used only for legacy components - don't use this for Block Kit
 def extract_json(
     item_or_items: Union[JsonObject, Sequence[JsonObject]], *format_args
-) -> Union[Dict[Any, Any], List[Dict[Any, Any]]]:
+) -> Union[Dict[Any, Any], List[Dict[Any, Any]], Sequence[JsonObject]]:
     """
     Given a sequence (or single item), attempt to call the to_dict() method on each
     item and return a plain list. If item is not the expected type, return it
@@ -24,11 +24,12 @@ def extract_json(
             method
     """
     try:
-        return [elem.to_dict(*format_args) if isinstance(elem, JsonObject) else elem for elem in item_or_items]
+        return [
+            elem.to_dict(*format_args) if isinstance(elem, JsonObject) else elem
+            for elem in item_or_items  # type: ignore[union-attr]
+        ]
     except TypeError:  # not iterable, so try returning it as a single item
-        return (
-            item_or_items.to_dict(*format_args) if isinstance(item_or_items, JsonObject) else item_or_items  # type: ignore
-        )
+        return item_or_items.to_dict(*format_args) if isinstance(item_or_items, JsonObject) else item_or_items
 
 
 def show_unknown_key_warning(name: Union[str, object], others: dict):

slack_sdk/models/attachments/__init__.py

@@ -212,7 +212,7 @@ class ActionExternalSelector(AbstractActionSelector):
     data_source = "external"
 
     @property
-    def attributes(self) -> Set[str]:
+    def attributes(self) -> Set[str]:  # type: ignore[override]
         return super().attributes.union({"min_query_length"})
 
     def __init__(
@@ -469,7 +469,7 @@ def to_dict(self) -> dict:
 
 class InteractiveAttachment(Attachment):
     @property
-    def attributes(self) -> Set[str]:
+    def attributes(self) -> Set[str]:  # type: ignore[override]
         return super().attributes.union({"callback_id"})
 
     actions_max_length = 5

slack_sdk/models/basic_objects.py

@@ -121,7 +121,7 @@ def wrapped_f(*args, **kwargs):
             if not func(*args, **kwargs):
                 raise SlackObjectFormationError(self.message)
 
-        wrapped_f.validator = True
+        wrapped_f.validator = True  # type: ignore[attr-defined]
         return wrapped_f