Skip to content

Commit f3f2adb

Browse files
committed
Update #1087 to have more relevant RetryHandler code
1 parent c496631 commit f3f2adb

File tree

9 files changed

+57
-9
lines changed

9 files changed

+57
-9
lines changed

docs-src/audit-logs/index.rst

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,13 @@ Creating your own ones is also quite simple. Defining a new class that inherits
9696
9797
client = AuditLogsClient(
9898
token=os.environ["SLACK_ORG_ADMIN_USER_TOKEN"],
99-
retry_handlers=[MyRetryHandler()],
99+
retry_handlers=[MyRetryHandler(
100+
max_retry_count=1,
101+
interval_calculator=BackoffRetryIntervalCalculator(
102+
backoff_factor=0.5,
103+
jitter=RandomJitter(),
104+
),
105+
)],
100106
)
101107
102108
For asyncio apps, ``Async`` prefixed corresponding modules are available. All the methods in those methods are async/await compatible. Check `the source code <https://github.com/slackapi/python-slack-sdk/blob/main/slack_sdk/http_retry/async_handler.py>`_ and `tests <https://github.com/slackapi/python-slack-sdk/blob/main/tests/slack_sdk_async/web/test_async_web_client_http_retry.py>`_ for more details.

docs-src/scim/index.rst

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,13 @@ Creating your own ones is also quite simple. Defining a new class that inherits
144144
145145
client = SCIMClient(
146146
token=os.environ["SLACK_ORG_ADMIN_USER_TOKEN"],
147-
retry_handlers=[MyRetryHandler()],
147+
retry_handlers=[MyRetryHandler(
148+
max_retry_count=1,
149+
interval_calculator=BackoffRetryIntervalCalculator(
150+
backoff_factor=0.5,
151+
jitter=RandomJitter(),
152+
),
153+
)],
148154
)
149155
150156
For asyncio apps, ``Async`` prefixed corresponding modules are available. All the methods in those methods are async/await compatible. Check `the source code <https://github.com/slackapi/python-slack-sdk/blob/main/slack_sdk/http_retry/async_handler.py>`_ and `tests <https://github.com/slackapi/python-slack-sdk/blob/main/tests/slack_sdk_async/web/test_async_web_client_http_retry.py>`_ for more details.

docs-src/web/index.rst

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -698,7 +698,13 @@ Creating your own ones is also quite simple. Defining a new class that inherits
698698
699699
client = WebClient(
700700
token=os.environ["SLACK_BOT_TOKEN"],
701-
retry_handlers=[MyRetryHandler()],
701+
retry_handlers=[MyRetryHandler(
702+
max_retry_count=1,
703+
interval_calculator=BackoffRetryIntervalCalculator(
704+
backoff_factor=0.5,
705+
jitter=RandomJitter(),
706+
),
707+
)],
702708
)
703709
704710
For asyncio apps, ``Async`` prefixed corresponding modules are available. All the methods in those methods are async/await compatible. Check `the source code <https://github.com/slackapi/python-slack-sdk/blob/main/slack_sdk/http_retry/async_handler.py>`_ and `tests <https://github.com/slackapi/python-slack-sdk/blob/main/tests/slack_sdk_async/web/test_async_web_client_http_retry.py>`_ for more details.

docs-src/webhook/index.rst

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,13 @@ Creating your own ones is also quite simple. Defining a new class that inherits
153153
154154
webhook = WebhookClient(
155155
url=url,
156-
retry_handlers=[MyRetryHandler()],
156+
retry_handlers=[MyRetryHandler(
157+
max_retry_count=1,
158+
interval_calculator=BackoffRetryIntervalCalculator(
159+
backoff_factor=0.5,
160+
jitter=RandomJitter(),
161+
),
162+
)],
157163
)
158164
159165
For asyncio apps, ``Async`` prefixed corresponding modules are available. All the methods in those methods are async/await compatible. Check `the source code <https://github.com/slackapi/python-slack-sdk/blob/main/slack_sdk/http_retry/async_handler.py>`_ and `tests <https://github.com/slackapi/python-slack-sdk/blob/main/tests/slack_sdk_async/web/test_async_web_client_http_retry.py>`_ for more details.

docs/audit-logs/index.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,13 @@ <h2>RetryHandler<a class="headerlink" href="#retryhandler" title="Permalink to t
285285

286286
<span class="n">client</span> <span class="o">=</span> <span class="n">AuditLogsClient</span><span class="p">(</span>
287287
<span class="n">token</span><span class="o">=</span><span class="n">os</span><span class="o">.</span><span class="n">environ</span><span class="p">[</span><span class="s2">&quot;SLACK_ORG_ADMIN_USER_TOKEN&quot;</span><span class="p">],</span>
288-
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">()],</span>
288+
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">(</span>
289+
<span class="n">max_retry_count</span><span class="o">=</span><span class="mi">1</span><span class="p">,</span>
290+
<span class="n">interval_calculator</span><span class="o">=</span><span class="n">BackoffRetryIntervalCalculator</span><span class="p">(</span>
291+
<span class="n">backoff_factor</span><span class="o">=</span><span class="mf">0.5</span><span class="p">,</span>
292+
<span class="n">jitter</span><span class="o">=</span><span class="n">RandomJitter</span><span class="p">(),</span>
293+
<span class="p">),</span>
294+
<span class="p">)],</span>
289295
<span class="p">)</span>
290296
</pre></div>
291297
</div>

docs/scim/index.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,13 @@ <h2>RetryHandler<a class="headerlink" href="#retryhandler" title="Permalink to t
332332

333333
<span class="n">client</span> <span class="o">=</span> <span class="n">SCIMClient</span><span class="p">(</span>
334334
<span class="n">token</span><span class="o">=</span><span class="n">os</span><span class="o">.</span><span class="n">environ</span><span class="p">[</span><span class="s2">&quot;SLACK_ORG_ADMIN_USER_TOKEN&quot;</span><span class="p">],</span>
335-
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">()],</span>
335+
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">(</span>
336+
<span class="n">max_retry_count</span><span class="o">=</span><span class="mi">1</span><span class="p">,</span>
337+
<span class="n">interval_calculator</span><span class="o">=</span><span class="n">BackoffRetryIntervalCalculator</span><span class="p">(</span>
338+
<span class="n">backoff_factor</span><span class="o">=</span><span class="mf">0.5</span><span class="p">,</span>
339+
<span class="n">jitter</span><span class="o">=</span><span class="n">RandomJitter</span><span class="p">(),</span>
340+
<span class="p">),</span>
341+
<span class="p">)],</span>
336342
<span class="p">)</span>
337343
</pre></div>
338344
</div>

docs/searchindex.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/web/index.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -779,7 +779,13 @@ <h2>RetryHandler<a class="headerlink" href="#retryhandler" title="Permalink to t
779779

780780
<span class="n">client</span> <span class="o">=</span> <span class="n">WebClient</span><span class="p">(</span>
781781
<span class="n">token</span><span class="o">=</span><span class="n">os</span><span class="o">.</span><span class="n">environ</span><span class="p">[</span><span class="s2">&quot;SLACK_BOT_TOKEN&quot;</span><span class="p">],</span>
782-
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">()],</span>
782+
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">(</span>
783+
<span class="n">max_retry_count</span><span class="o">=</span><span class="mi">1</span><span class="p">,</span>
784+
<span class="n">interval_calculator</span><span class="o">=</span><span class="n">BackoffRetryIntervalCalculator</span><span class="p">(</span>
785+
<span class="n">backoff_factor</span><span class="o">=</span><span class="mf">0.5</span><span class="p">,</span>
786+
<span class="n">jitter</span><span class="o">=</span><span class="n">RandomJitter</span><span class="p">(),</span>
787+
<span class="p">),</span>
788+
<span class="p">)],</span>
783789
<span class="p">)</span>
784790
</pre></div>
785791
</div>

docs/webhook/index.html

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,13 @@ <h2>RetryHandler<a class="headerlink" href="#retryhandler" title="Permalink to t
343343

344344
<span class="n">webhook</span> <span class="o">=</span> <span class="n">WebhookClient</span><span class="p">(</span>
345345
<span class="n">url</span><span class="o">=</span><span class="n">url</span><span class="p">,</span>
346-
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">()],</span>
346+
<span class="n">retry_handlers</span><span class="o">=</span><span class="p">[</span><span class="n">MyRetryHandler</span><span class="p">(</span>
347+
<span class="n">max_retry_count</span><span class="o">=</span><span class="mi">1</span><span class="p">,</span>
348+
<span class="n">interval_calculator</span><span class="o">=</span><span class="n">BackoffRetryIntervalCalculator</span><span class="p">(</span>
349+
<span class="n">backoff_factor</span><span class="o">=</span><span class="mf">0.5</span><span class="p">,</span>
350+
<span class="n">jitter</span><span class="o">=</span><span class="n">RandomJitter</span><span class="p">(),</span>
351+
<span class="p">),</span>
352+
<span class="p">)],</span>
347353
<span class="p">)</span>
348354
</pre></div>
349355
</div>

0 commit comments

Comments
 (0)