Skip to content

Commit 693ad8b

Browse files
committed
temp: what is the fingerprint doing in ci lets find out
1 parent c9e3a29 commit 693ad8b

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

.github/workflows/tests.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@ jobs:
4848
matrix:
4949
include:
5050
- os: ubuntu-latest
51-
path: echo "$HOME/.slack/bin" >> "$GITHUB_PATH"
52-
script: bash ./scripts/install.sh
51+
# path: echo "$HOME/.slack/bin" >> "$GITHUB_PATH"
52+
script: ./scripts/install.sh
5353
- os: windows-latest
54-
path: Add-Content -Path $env:GITHUB_PATH -Value "$env:USERPROFILE\.slack\bin"
55-
script: pwsh ./scripts/install-windows.ps1
54+
# path: Add-Content -Path $env:GITHUB_PATH -Value "$env:USERPROFILE\.slack\bin"
55+
script: ./scripts/install-windows.ps1
5656
runs-on: ${{ matrix.os }}
5757
permissions:
5858
contents: read
@@ -61,8 +61,8 @@ jobs:
6161
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
6262
with:
6363
persist-credentials: false
64-
- name: Configure the path
65-
run: ${{ matrix.path }}
64+
# - name: Configure the path
65+
# run: ${{ matrix.path }}
6666
- name: Attempt the installation
6767
run: ${{ matrix.script }}
6868

scripts/install-windows.ps1

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function check_slack_binary_exist() {
5252
$SLACK_CLI_NAME = $alias
5353
}
5454
Write-Host "xd3: $SLACK_CLI_NAME"
55-
& $SLACK_CLI_NAME _fingerprint
55+
# & $SLACK_CLI_NAME _fingerprint
5656
if (Get-Command $SLACK_CLI_NAME -ErrorAction SilentlyContinue) {
5757
if ($Diagnostics) {
5858
delay 0.3 "Checking if ``$SLACK_CLI_NAME`` already exists on this system..."
@@ -167,6 +167,15 @@ function install_slack_cli {
167167
[System.Environment]::SetEnvironmentVariable('Path', $Path.TrimEnd(';') + ";${slack_cli_bin_dir}", $User)
168168
$Env:Path = $Env:Path.TrimEnd(';') + ";$slack_cli_bin_dir"
169169
}
170+
171+
$old = $ErrorActionPreference
172+
$ErrorActionPreference = 'Continue'
173+
try {
174+
$fp = (& $SLACK_CLI_NAME _fingerprint 2>&1 | Out-String).Trim()
175+
} finally {
176+
$ErrorActionPreference = $old
177+
}
178+
170179
Remove-Item "$($slack_cli_dir)\slack_cli.zip"
171180
}
172181

0 commit comments

Comments
 (0)