refactor: enable linter ST1008 'function's error value should be its last return value'

Author: mwbrooks

.golangci.yml

@@ -36,7 +36,6 @@ linters:
         - '-ST1003' # disable rule 'Poorly chosen identifier'
         - '-ST1005' # disable rule 'Incorrectly formatted error string'
         - '-ST1006' # disable rule 'Poorly chosen receiver name'
-        - '-ST1008' # disable rule 'Function’s error value should be its last return value'
         - '-ST1023' # disable rule 'Redundant type in variable declaration'
         - '-QF1001' # disable rule 'Apply De Morgan’s law'
         - '-QF1012' # disable rule 'Use fmt.Fprintf instead of x.Write(fmt.Sprintf(...))'

cmd/root_test.go

@@ -237,15 +237,15 @@ func Test_Aliases(t *testing.T) {
 	}
 	for name, tt := range tests {
 		t.Run(name, func(t *testing.T) {
-			err, output := testExecCmd(ctx, strings.Fields(tt.args))
+			output, err := testExecCmd(ctx, strings.Fields(tt.args))
 			require.NoError(t, err)
 			require.Contains(t, output, tt.expected)
 		})
 	}
 }
 
 // testExecCmd will execute the root cobra command with args and return the output
-func testExecCmd(ctx context.Context, args []string) (error, string) {
+func testExecCmd(ctx context.Context, args []string) (string, error) {
 	// Get command
 	cmd, clients := Init(ctx)
 
@@ -258,7 +258,7 @@ func testExecCmd(ctx context.Context, args []string) (error, string) {
 	cmd.SetArgs(args)
 	err := cmd.ExecuteContext(ctx)
 	if err != nil {
-		return err, ""
+		return "", err
 	}
-	return nil, clientsMock.GetCombinedOutput()
+	return clientsMock.GetCombinedOutput(), nil
 }