error out when flag not provided

Author: vegeris

cmd/collaborators/update.go

@@ -15,12 +15,11 @@
 package collaborators
 
 import (
-	"context"
+	"fmt"
 	"net/mail"
 
 	"github.com/opentracing/opentracing-go"
 	"github.com/slackapi/slack-cli/internal/cmdutil"
-	"github.com/slackapi/slack-cli/internal/iostreams"
 	"github.com/slackapi/slack-cli/internal/prompts"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/shared/types"
@@ -59,7 +58,7 @@ func NewUpdateCommand(clients *shared.ClientFactory) *cobra.Command {
 		"collaborator permission type\n(\"%s\" or \"%s\")",
 		string(types.OWNER),
 		string(types.READER),
-	))```
+	))
 
 	return cmd
 }
@@ -84,10 +83,8 @@ func runUpdateCommand(cmd *cobra.Command, clients *shared.ClientFactory, args []
 			return err
 		}
 	} else {
-		slackUser.PermissionType, err = promptCollaboratorPermissionSelection(ctx, clients)
-		if err != nil {
-			return err
-		}
+		cmd.Println(fmt.Sprintf("\n%s Specify a permission type for your collaborator with the %s flag\n", style.Emoji("warning"), style.Highlight("--permission-type")))
+		return nil
 	}
 
 	// Get the app auth selection from the flag or prompt
@@ -111,29 +108,3 @@ func runUpdateCommand(cmd *cobra.Command, clients *shared.ClientFactory, args []
 
 	return nil
 }
-
-// promptCollaboratorPermissionSelection fetches collaborator permission from the prompt
-func promptCollaboratorPermissionSelection(
-	ctx context.Context,
-	clients *shared.ClientFactory,
-) (
-	permission types.AppCollaboratorPermission,
-	err error,
-) {
-	permissionLabels := []string{
-		"owner",
-		"reader",
-	}
-	response, err := clients.IO.SelectPrompt(
-		ctx,
-		"Select a permission type",
-		permissionLabels,
-		iostreams.SelectPromptConfig{
-			Required: true,
-		},
-	)
-	if err != nil {
-		return "", err
-	}
-	return types.StringToAppCollaboratorPermission(response.Option)
-}

cmd/collaborators/update_test.go

@@ -18,7 +18,6 @@ import (
 	"context"
 	"testing"
 
-	"github.com/slackapi/slack-cli/internal/iostreams"
 	"github.com/slackapi/slack-cli/internal/prompts"
 	"github.com/slackapi/slack-cli/internal/shared"
 	"github.com/slackapi/slack-cli/internal/shared/types"
@@ -59,26 +58,14 @@ func TestUpdateCommand(t *testing.T) {
 					types.SlackUser{Email: "[email protected]", PermissionType: types.OWNER}).Return(nil)
 			},
 		},
-		"prompts when permission type not specified": {
+		"permission type must be specified": {
 			CmdArgs:         []string{"[email protected]"},
-			ExpectedOutputs: []string{"[email protected] successfully updated as a reader collaborator on this app"},
+			ExpectedOutputs: []string{"Specify a permission type for your collaborator"},
 			Setup: func(t *testing.T, ctx context.Context, clientsMock *shared.ClientsMock, clients *shared.ClientFactory) {
 				clientsMock.AddDefaultMocks()
-				// Mock app selection
-				appSelectMock := prompts.NewAppSelectMock()
-				appSelectPromptFunc = appSelectMock.AppSelectPrompt
-				appSelectMock.On("AppSelectPrompt", mock.Anything, mock.Anything, prompts.ShowHostedOnly, prompts.ShowInstalledAndUninstalledApps).Return(prompts.SelectedApp{App: types.App{AppID: "A123"}, Auth: types.SlackAuth{}}, nil)
-				// Mock permission selection prompt
-				clientsMock.IO.On("SelectPrompt", mock.Anything, "Select a permission type", mock.Anything, mock.Anything).Return(
-					iostreams.SelectPromptResponse{
-						Prompt: true,
-						Option: "reader",
-						Index:  1,
-					}, nil)
-				// Mock API call
-				clientsMock.API.On("UpdateCollaborator", mock.Anything, mock.Anything,
-					"A123",
-					types.SlackUser{Email: "[email protected]", PermissionType: types.READER}).Return(nil)
+				// Set experiment flag
+				clientsMock.Config.ExperimentsFlag = append(clientsMock.Config.ExperimentsFlag, "read-only-collaborators")
+				clientsMock.Config.LoadExperiments(ctx, clientsMock.IO.PrintDebug)
 			},
 		},
 		"user ID must be provided": {