feat: accept the app name as an argument to the 'samples' command (#140)

Author: zimeg

cmd/project/samples.go

@@ -30,14 +30,17 @@ var samplesLanguageFlag string
 
 func NewSamplesCommand(clients *shared.ClientFactory) *cobra.Command {
 	cmd := &cobra.Command{
-		Use:     "samples",
+		Use:     "samples [name]",
 		Aliases: []string{"sample"},
 		Short:   "List available sample apps",
 		Long:    "List and create an app from the available samples",
 		Example: style.ExampleCommandsf([]style.ExampleCommand{
-			{Command: "samples", Meaning: "Select a sample app to create"},
+			{
+				Meaning: "Select a sample app to create",
+				Command: "samples my-project",
+			},
 		}),
-		Args: cobra.MaximumNArgs(0),
+		Args: cobra.MaximumNArgs(1),
 		RunE: func(cmd *cobra.Command, args []string) error {
 			clients.Config.SetFlags(cmd)
 			return runSamplesCommand(clients, cmd, args)
@@ -77,9 +80,7 @@ func runSamplesCommand(clients *shared.ClientFactory, cmd *cobra.Command, args [
 
 	// If preferred directory name is passed in as an argument to the `create`
 	// command first, honor that preference and use it to create the project
-	if len(args) > 0 {
-		createCmd.SetArgs([]string{args[0]})
-	}
+	createCmd.SetArgs(args)
 
 	// Execute the `create` command with the set flag
 	return createCmd.ExecuteContext(ctx)

cmd/project/samples_test.go

@@ -32,7 +32,7 @@ import (
 func TestSamplesCommand(t *testing.T) {
 	testutil.TableTestCommand(t, testutil.CommandTests{
 		"creates a template from a trusted sample": {
-			CmdArgs: []string{},
+			CmdArgs: []string{"my-sample-app"},
 			Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
 				createPkg.GetSampleRepos = func(client createPkg.Sampler) ([]createPkg.GithubRepo, error) {
 					repos := []createPkg.GithubRepo{
@@ -72,9 +72,12 @@ func TestSamplesCommand(t *testing.T) {
 						nil,
 					)
 				CreateFunc = func(ctx context.Context, clients *shared.ClientFactory, log *logger.Logger, createArgs createPkg.CreateArgs) (appDirPath string, err error) {
-					return "", nil
+					return createArgs.AppName, nil
 				}
 			},
+			ExpectedOutputs: []string{
+				"cd my-sample-app/",
+			},
 			ExpectedAsserts: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock) {
 				for _, call := range cm.IO.Calls {
 					switch call.Method {