diff --git a/.github/MAINTAINERS_GUIDE.md b/.github/MAINTAINERS_GUIDE.md index 9c621cad..8043b2a3 100644 --- a/.github/MAINTAINERS_GUIDE.md +++ b/.github/MAINTAINERS_GUIDE.md @@ -750,6 +750,10 @@ Steps to merge a pull request: 1. Tests must pass on the pull request using the continuous integration suite - Tests for development APIs are optional, but we recommend investigating why it's failing before merging + - End-to-end tests for pull requests from forks can be [started][e2e] if: + - The `workflow` from the **main** branch is used + - The `branch` contains the pull request number as: `pull/123/head` + - The `status` is reported with the commit checks 2. Code is reviewed and approved by another maintainer 3. Title is descriptive - This becomes part of the CHANGELOG, so please make sure it's meaningful to @@ -770,6 +774,7 @@ When in doubt, find the other maintainers and ask. [commit]: https://www.conventionalcommits.org/en/v1.0.0/ [contributing]: ./CONTRIBUTING.md [dev-release]: https://github.com/slackapi/slack-cli/releases/tag/dev-build +[e2e]: https://github.com/slackapi/slack-cli/actions/workflows/e2e_tests.yml [effective-go]: https://golang.org/doc/effective_go [github-app]: https://github.com/apps/slack-cli-releaser [goinstaller]: https://go.dev/doc/install diff --git a/.github/workflows/e2e_tests.yml b/.github/workflows/e2e_tests.yml index ce55eed2..6dbf2854 100644 --- a/.github/workflows/e2e_tests.yml +++ b/.github/workflows/e2e_tests.yml @@ -5,17 +5,32 @@ on: workflow_dispatch: inputs: branch: - description: 'The branch to build' + description: "The branch to build" + required: true + status: + description: "Report test status" + default: false + type: boolean required: true jobs: execute: + name: Start tests runs-on: ubuntu-latest steps: - - name: Trigger CircleCI build-beta workflow. + - name: Trigger CircleCI 'local' workflow + if: ${{ github.event.inputs.status == 'false' }} uses: promiseofcake/circleci-trigger-action@v1.7.8 with: user-token: ${{ secrets.CIRCLECI_TOKEN }} project-slug: slackapi/slack-cli branch: ${{ github.event.inputs.branch }} payload: '{"run_local_build_test_workflow": true}' + - name: Trigger CircleCI 'e2e' workflow + if: ${{ github.event.inputs.status == 'true' }} + uses: promiseofcake/circleci-trigger-action@v1.7.8 + with: + user-token: ${{ secrets.CIRCLECI_TOKEN }} + project-slug: slackapi/slack-cli + branch: ${{ github.event.inputs.branch }} + payload: '{"run_local_build_test_workflow": false}'