Skip to content

Commit 96f0e16

Browse files
authored
Merge pull request #1083 from slaclab/pre-release
Release Candidate v6.7.0
2 parents ef7f866 + f5fee8f commit 96f0e16

File tree

30 files changed

+163
-176
lines changed

30 files changed

+163
-176
lines changed

.github/workflows/rogue_ci.yml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
# The following environment variables are required for this process:
1313
# secrets.GH_TOKEN
1414
# secrets.CONDA_UPLOAD_TOKEN_TAG
15-
# secrets.DOCKERHUB_TOKEN
1615

1716
name: Rogue Integration
1817
on: [push]
@@ -55,18 +54,10 @@ jobs:
5554
exit 1
5655
fi
5756
58-
# Python Linter
59-
- name: Python Linter
57+
# Run Linters
58+
- name: Python and C++ Linters
6059
run: |
61-
python -m compileall -f ./python/
62-
flake8 --count ./python/
63-
python -m compileall -f ./tests
64-
flake8 --count ./tests/
65-
66-
# C++ Linter
67-
- name: C++ Linter
68-
run: |
69-
find . -name '*.h' -o -name '*.cpp' | xargs cpplint
60+
./scripts/run_linters.sh
7061
7162
# Rogue
7263
- name: Build Rogue

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,4 @@ bld-dir/*
2222
/linuxRT-x86_64
2323
/rhel6-x86_64
2424
/rhel7-x86_64
25+
rogue.egg-info*

CMakeLists.txt

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,30 +73,30 @@ if ( NOT NO_PYTHON )
7373
endif()
7474

7575
# libboost_python3.7 style libraries
76-
message("Looking for libboost_python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}")
76+
message("Looking for libboost_python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR} Mode 1")
7777
FIND_PACKAGE(Boost 1.58 QUIET COMPONENTS python${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR})
7878

7979
# libboost_python3 style libraries
8080
if (NOT Boost_FOUND)
81-
message("Looking for libboost_python${Python3_VERSION_MAJOR}")
81+
message("Looking for libboost_python${Python3_VERSION_MAJOR} Mode 2")
8282
FIND_PACKAGE(Boost 1.58 QUIET COMPONENTS python${Python3_VERSION_MAJOR})
8383
endif()
8484

8585
# libboost_python style libraries
8686
if (NOT Boost_FOUND)
87-
message("Looking for libboost_python")
87+
message("Looking for libboost_python Mode 3")
8888
FIND_PACKAGE(Boost 1.58 QUIET COMPONENTS system thread python)
8989
endif()
9090

9191
# libboost_python-py37 style libraries
9292
if (NOT Boost_FOUND)
93-
message("Looking for libboost_python-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}")
93+
message("Looking for libboost_python-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR} Mode 4")
9494
FIND_PACKAGE(Boost 1.58 QUIET COMPONENTS python-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR})
9595
endif()
9696

9797
# libboost_python3-py37 style libraries
9898
if (NOT Boost_FOUND)
99-
message("Looking for libboost_python3-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR}")
99+
message("Looking for libboost_python3-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR} Mode 5")
100100
FIND_PACKAGE(Boost 1.58 QUIET COMPONENTS python3-py${Python3_VERSION_MAJOR}${Python3_VERSION_MINOR})
101101
endif()
102102

@@ -236,7 +236,6 @@ include_directories(system ${Python3_INCLUDE_DIRS})
236236
include_directories(system ${Python3_NumPy_INCLUDE_DIRS})
237237
include_directories(system ${ZeroMQ_INCLUDE_DIR})
238238
include_directories(system ${BZIP2_INCLUDE_DIR})
239-
include_directories(system ${EPICS_INCLUDES})
240239

241240
if (APPLE)
242241
SET(CMAKE_SHARED_LIBRARY_SUFFIX ".dylib")
@@ -259,7 +258,6 @@ set_target_properties(rogue-core-shared PROPERTIES VERSION ${ROGUE_VERSION} SOVE
259258

260259
TARGET_LINK_LIBRARIES(rogue-core-shared PUBLIC ${Boost_LIBRARIES})
261260
TARGET_LINK_LIBRARIES(rogue-core-shared PUBLIC ${ZeroMQ_LIBRARY})
262-
TARGET_LINK_LIBRARIES(rogue-core-shared PUBLIC ${EPICS_LIBRARIES})
263261
TARGET_LINK_LIBRARIES(rogue-core-shared PUBLIC ${BZIP2_LIBRARIES})
264262

265263
# Do not link directly against python in mac os
@@ -278,7 +276,6 @@ if(STATIC_LIB)
278276
# Link rogue core to boost, python and bzip
279277
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC ${Boost_LIBRARIES})
280278
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC ${ZeroMQ_LIBRARY})
281-
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC ${EPICS_LIBRARIES})
282279
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC ${BZIP2_LIBRARIES})
283280
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC ${Python3_LIBRARIES})
284281
TARGET_LINK_LIBRARIES(rogue-core-static PUBLIC rt)

buildroot-2019.08-x86_64.cmake

Lines changed: 0 additions & 35 deletions
This file was deleted.

buildroot-2019.08-x86_64_cmake.sh

Lines changed: 0 additions & 11 deletions
This file was deleted.

conda-recipe/conda_build_config.yaml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,13 @@ python:
55
- 3.11
66
- 3.12
77

8-
# Use NumPy minors that exist for each Python
9-
numpy:
10-
- 1.26 # py39
11-
- 1.26 # py310
12-
- 1.26 # py311
13-
- 1.26 # py312
14-
158
###############################################################################################
169
# Notes for checking if conda solution exist before doing the actual conda build
1710
###############################################################################################
18-
# conda render conda-recipe --variants "{python: 3.9, numpy: 1.26, python_abi: '3.9 *_cp39' }"
19-
# conda render conda-recipe --variants "{python: 3.10, numpy: 1.26, python_abi: '3.10 *_cp310'}"
20-
# conda render conda-recipe --variants "{python: 3.11, numpy: 1.26, python_abi: '3.11 *_cp311'}"
21-
# conda render conda-recipe --variants "{python: 3.12, numpy: 1.26, python_abi: '3.12 *_cp312'}"
11+
# conda render conda-recipe --variants "{python: 3.9, python_abi: '3.9 *_cp39' }"
12+
# conda render conda-recipe --variants "{python: 3.10, python_abi: '3.10 *_cp310'}"
13+
# conda render conda-recipe --variants "{python: 3.11, python_abi: '3.11 *_cp311'}"
14+
# conda render conda-recipe --variants "{python: 3.12, python_abi: '3.12 *_cp312'}"
2215
###############################################################################################
2316

2417
# Lock to CPython ABI, not PyPy
@@ -35,7 +28,7 @@ python_impl:
3528
- cpython # py312
3629

3730
zip_keys:
38-
- [python, numpy, python_abi, python_impl]
31+
- [python, python_abi, python_impl]
3932

4033
pin_run_as_build:
4134
python: {min_pin: x.x, max_pin: x.x}

conda-recipe/meta.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ requirements:
2020
- bzip2
2121
- zeromq
2222
- python {{ python }} # declare python variants in conda_build_config.yaml
23-
- numpy {{ numpy }} # declare numpy variants in conda_build_config.yaml
23+
- numpy>=2.0
2424
run:
2525
- python
2626
- boost
2727
- bzip2
2828
- zeromq
29-
- numpy
29+
- numpy>=2.0
3030
- ipython
3131
- pyyaml
3232
- jsonpickle

docker/rogue/Dockerfile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ RUN mkdir build
2929
WORKDIR build
3030
RUN cmake .. -DROGUE_INSTALL=system
3131
RUN make -j4 install
32-
RUN echo /usr/local/lib >> /etc/ld.so.conf.d/rogue_epics.conf
3332
RUN ldconfig
3433
ENV PYQTDESIGNERPATH /usr/local/lib/python3.10/dist-packages/pyrogue/pydm
3534
ENV PYDM_DATA_PLUGINS_PATH /usr/local/lib/python3.10/dist-packages/pyrogue/pydm/data_plugins

docs/src/installing/docker.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Installing Rogue Docker
55
=======================
66

7-
Docker images with rogue are automatically generated and uploaded to Docker hub, in the following repositories:
7+
Docker images with rogue are automatically generated and uploaded to GitHub Container Registry (GHCR), in the following repositories:
88

99
Docker images are created for tagged version of rogue:
1010
https://ghcr.io/slaclab/rogue

docs/src/installing/miniforge_build.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Once the rogue environment is activated, you can build and install rogue
6262
$ mkdir build
6363
$ cd build
6464
$ cmake ..
65-
$ make
65+
$ make -j$(nproc)
6666
$ make install
6767
6868
The Rogue build system will automatically detect that it is in a conda environment and it will be installed

0 commit comments

Comments
 (0)