SD-1579: remove OrderedSet constructor (#3)

Per discussion with @sellout & @jdegoes

https://slamdata.atlassian.net/browse/SD-1579

Author: jonsterling

src/Data/Json/Extended.purs

@@ -16,7 +16,6 @@ module Data.Json.Extended
   , time
   , interval
   , objectId
-  , orderedSet
   , object
   , object'
   , array
@@ -186,9 +185,6 @@ interval = roll <<< Sig.Interval
 objectId ∷ String → EJson
 objectId = roll <<< Sig.ObjectId
 
-orderedSet ∷ Array EJson → EJson
-orderedSet = roll <<< Sig.OrderedSet
-
 array ∷ Array EJson → EJson
 array = roll <<< Sig.Array
 

src/Data/Json/Extended/Signature/Core.purs

@@ -29,7 +29,6 @@ data EJsonF a
   | Interval String
   | ObjectId String
   | Array (Array a)
-  | OrderedSet (Array a)
   | Object (Array (T.Tuple a a))
 
 instance functorEJsonF ∷ Functor EJsonF where
@@ -46,7 +45,6 @@ instance functorEJsonF ∷ Functor EJsonF where
       Interval i → Interval i
       ObjectId oid → ObjectId oid
       Array xs → Array $ f <$> xs
-      OrderedSet xs → OrderedSet $ f <$> xs
       Object xs → Object $ BF.bimap f f <$> xs
 
 instance eq1EJsonF ∷ Eq1 EJsonF where
@@ -62,7 +60,6 @@ instance eq1EJsonF ∷ Eq1 EJsonF where
   eq1 (Time a) (Time b) = a == b
   eq1 (Interval a) (Interval b) = a == b
   eq1 (ObjectId a) (ObjectId b) = a == b
-  eq1 (OrderedSet xs) (OrderedSet ys) = xs == ys
   eq1 (Array xs) (Array ys) = xs == ys
   eq1 (Object xs) (Object ys) =
     let
@@ -137,10 +134,6 @@ instance ord1EJsonF ∷ Ord1 EJsonF where
   compare1 _ (ObjectId _) = GT
   compare1 (ObjectId _) _ = LT
 
-  compare1 (OrderedSet a) (OrderedSet b) = compare a b
-  compare1 _ (OrderedSet _) = GT
-  compare1 (OrderedSet _) _ = LT
-
   compare1 (Array a) (Array b) = compare a b
   compare1 _ (Array _) = GT
   compare1 (Array _) _ = LT

src/Data/Json/Extended/Signature/Gen.purs

@@ -38,7 +38,6 @@ arbitraryEJsonFWithKeyGen
 arbitraryEJsonFWithKeyGen keyGen rec =
   Gen.oneOf (pure Null)
     [ arbitraryBaseEJsonF
-    , OrderedSet <$> Gen.arrayOf rec
     , Array <$> Gen.arrayOf rec
     , Object <$> do
         keys ← distinctArrayOf keyGen

src/Data/Json/Extended/Signature/Json.purs

@@ -41,7 +41,6 @@ encodeJsonEJsonF rec asKey x =
     Date str → JS.jsonSingletonObject "$date" $ encodeJson str
     Interval str → JS.jsonSingletonObject "$interval" $ encodeJson str
     ObjectId str → JS.jsonSingletonObject "$oid" $ encodeJson str
-    OrderedSet xs → JS.jsonSingletonObject "$set" $ encodeJson $ rec <$> xs
     Array xs → encodeJson $ rec <$> xs
     Object xs → JS.jsonSingletonObject "$obj" $ encodeJson $ asStrMap xs
       where
@@ -133,7 +132,6 @@ decodeJsonEJsonF rec makeKey =
       → E.Either String (EJsonF a)
     decodeObject obj =
       unwrapBranch "$obj" strMapObject obj
-        <|> unwrapBranch "$set" OrderedSet obj
         <|> unwrapLeaf "$timestamp" Timestamp obj
         <|> unwrapLeaf "$date" Date obj
         <|> unwrapLeaf "$time" Time obj

src/Data/Json/Extended/Signature/Parse.purs

@@ -260,7 +260,6 @@ parseEJsonF rec =
     , Date <$> taggedLiteral "DATE"
     , Interval <$> taggedLiteral "INTERVAL"
     , ObjectId <$> taggedLiteral "OID"
-    , OrderedSet <<< L.fromList <$> parens (commaSep rec)
     , Array <<< L.fromList <$> squares (commaSep rec)
     , Object <<< L.fromList <$> braces (commaSep parseAssignment)
     ]

src/Data/Json/Extended/Signature/Render.purs

@@ -28,7 +28,6 @@ renderEJsonF rec d =
     Date str → tagged "DATE" str
     Interval str → tagged "INTERVAL" str
     ObjectId str → tagged "OID" str
-    OrderedSet ds → parens $ commaSep ds
     Array ds → squares $ commaSep ds
     Object ds → braces $ renderPairs ds
   where