-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Milestone
Description
Currently, it is theoretically possible to attempt selecting a range below 0.
-
/code entityaroundshould be greater than 0
-
/code linesstartandendshould be greater than 1
This is currently the only check in place, checking if startLine exceeds the total line count of the file.
Lines 136 to 145 in 9bafefb
| if (startLine > lines.length) { | |
| return { | |
| ephemeral: true, | |
| content: [ | |
| `**Failover:** Line selection out of bounds.`, | |
| `> Start Line: \`${startLine + 1}\``, | |
| `> Total Lines: \`${lines.length}\`` | |
| ].join('\n') | |
| }; | |
| } |
#50 could easily be thrown out and have an error returned instead, for which an onError method could be added.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request