Skip to content
This repository was archived by the owner on Apr 23, 2021. It is now read-only.

Commit 613b53e

Browse files
authored
Merge pull request #31 from ktoso/wip-logger-not-set
!logging #30 logger need not be { set }
2 parents 5f4ae4a + bc38a06 commit 613b53e

File tree

2 files changed

+3
-13
lines changed

2 files changed

+3
-13
lines changed

Sources/BaggageLogging/LoggingBaggageContextCarrier.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,5 @@ public protocol LoggingBaggageContextCarrier: BaggageContextCarrier {
2929
///
3030
/// Writes to the `logger` metadata SHOULD NOT be reflected in the `baggage`,
3131
/// however writes to the underlying `baggage` SHOULD be reflected in the `logger`.
32-
var logger: Logger { get set }
32+
var logger: Logger { get }
3333
}

Tests/BaggageLoggingTests/LoggingBaggageContextCarrierTests.swift

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,7 @@ public struct ExampleFrameworkContext: LoggingBaggageContextCarrier {
7171

7272
private var _logger: Logger
7373
public var logger: Logger {
74-
get {
75-
return self._logger.with(context: self.baggage)
76-
}
77-
set {
78-
self._logger = newValue
79-
}
74+
return self._logger.with(context: self.baggage)
8075
}
8176

8277
public init(context baggage: BaggageContext, logger: Logger) {
@@ -88,12 +83,7 @@ public struct ExampleFrameworkContext: LoggingBaggageContextCarrier {
8883
struct CoolFrameworkContext: LoggingBaggageContextCarrier {
8984
private var _logger: Logger = Logger(label: "some frameworks logger")
9085
var logger: Logger {
91-
get {
92-
return self._logger.with(context: self.baggage)
93-
}
94-
set {
95-
self._logger = newValue
96-
}
86+
return self._logger.with(context: self.baggage)
9787
}
9888

9989
var baggage: BaggageContext = .init()

0 commit comments

Comments
 (0)