Skip to content

Commit 1e5d304

Browse files
committed
Merge tag 'ctsm5.4.016' into cruncep20260129
Merge b4b-dev to master slevis resolved conflicts: doc/ChangeLog doc/ChangeSum
2 parents 8e2e85b + 96b9398 commit 1e5d304

35 files changed

+4607
-1573
lines changed

.git-blame-ignore-revs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,3 +76,4 @@ cdf40d265cc82775607a1bf25f5f527bacc97405
7676
ac03492012837799b7111607188acff9f739044a
7777
d858665d799690d73b56bcb961684382551193f4
7878
c0c6da391ee359f2765439426f3a2a4593a95343
79+
598de2f05638286b3d99ac0ed120977cbc554c3d

bld/namelist_files/namelist_defaults_ctsm.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -703,6 +703,7 @@ attributes from the config_cache.xml file (with keys converted to upper-case).
703703

704704
<generate_crop_gdds >.false.</generate_crop_gdds>
705705
<use_mxmat >.true.</use_mxmat>
706+
<suppress_gddmaturity_warning >.false.</suppress_gddmaturity_warning>
706707

707708
<!-- use additional stress deciduous onset trigger -->
708709
<constrain_stress_deciduous_onset >.true.</constrain_stress_deciduous_onset>

bld/namelist_files/namelist_definition_ctsm.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,6 +1484,11 @@ Set to .true. in order to override crop harvesting logic and to instead harvest
14841484
Set to .false. in order to ignore crop PFT parameter for maximum growing season length (mxmat). Must be set to .false. when generate_crop_gdds is .true.
14851485
</entry>
14861486

1487+
<entry id="suppress_gddmaturity_warning" type="logical" category="physics"
1488+
group="cnphenology" valid_values="" value=".false.">
1489+
If set to .true., suppress the warning message when a prescribed cultivar GDD requirement is below the minimum allowed value and is replaced with min_gddmaturity. Useful when using prescribed crop calendars with intentionally low GDD requirements.
1490+
</entry>
1491+
14871492
<entry id="min_critical_dayl_method" type="char*25" category="physics"
14881493
group="cnphenology" valid_values="Constant,DependsOnLat,DependsOnVeg,DependsOnLatAndVeg">
14891494
Method for determining what the minimum critical day length for seasonal decidious leaf offset depends on

cime_config/SystemTests/rxcropmaturity.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -448,6 +448,7 @@ def _run_generate_gdds(self, case_gddgen):
448448
f"--hdates-file {hdates_file}",
449449
f"--output-dir generate_gdds_out",
450450
f"--skip-crops miscanthus,irrigated_miscanthus,switchgrass,irrigated_switchgrass",
451+
"--max-season-length-from-hdates-file",
451452
]
452453
)
453454
stu.run_python_script(

cime_config/testdefs/ExpectedTestFails.xml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,27 @@
3636
</phase>
3737
</test>
3838

39+
<test name="RXCROPMATURITY_Lm61.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput">
40+
<phase name="RUN">
41+
<status>FAIL</status>
42+
<issue>#3740</issue>
43+
</phase>
44+
</test>
45+
46+
<test name="RXCROPMATURITY_Lm61.f09_t232.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput">
47+
<phase name="RUN">
48+
<status>FAIL</status>
49+
<issue>#3740</issue>
50+
</phase>
51+
</test>
52+
53+
<test name="RXCROPMATURITY_Lm61.f09_g17.IHistClm60BgcCrop.derecho_intel.clm-cropMonthOutput">
54+
<phase name="RUN">
55+
<status>FAIL</status>
56+
<issue>#3740</issue>
57+
</phase>
58+
</test>
59+
3960
<test name="SMS_Ld5.f09_g17.IHistClm50Sp.derecho_intel.clm-nofire">
4061
<phase name="SHAREDLIB_BUILD">
4162
<status>FAIL</status>

cime_config/testdefs/testmods_dirs/clm/crop/user_nl_clm

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ hist_fincl2 += 'DYN_COL_SOIL_ADJUSTMENTS_C'
1313
! Note that, under normal circumstances, these should only be saved annually.
1414
! That's needed for the mxsowings and mxharvests axes to make sense.
1515
! However, for testing purposes, it makes sense to save more frequently.
16-
hist_fincl3 = 'SDATES', 'SDATES_PERHARV', 'SYEARS_PERHARV', 'HDATES', 'GRAINC_TO_FOOD_PERHARV', 'GRAINC_TO_FOOD_ANN', 'GRAINN_TO_FOOD_PERHARV', 'GRAINN_TO_FOOD_ANN', 'GRAINC_TO_SEED_PERHARV', 'GRAINC_TO_SEED_ANN', 'GRAINN_TO_SEED_PERHARV', 'GRAINN_TO_SEED_ANN', 'HDATES', 'GDDHARV_PERHARV', 'GDDACCUM_PERHARV', 'HUI_PERHARV', 'SOWING_REASON_PERHARV', 'HARVEST_REASON_PERHARV', 'SWINDOW_STARTS', 'SWINDOW_ENDS', 'GDD20_BASELINE', 'GDD20_SEASON_START', 'GDD20_SEASON_END'
16+
hist_fincl3 = 'SDATES', 'SDATES_PERHARV', 'SYEARS_PERHARV', 'HDATES', 'GRAINC_TO_FOOD_PERHARV', 'GRAINC_TO_FOOD_ANN', 'GRAINN_TO_FOOD_PERHARV', 'GRAINN_TO_FOOD_ANN', 'GRAINC_TO_SEED_PERHARV', 'GRAINC_TO_SEED_ANN', 'GRAINN_TO_SEED_PERHARV', 'GRAINN_TO_SEED_ANN', 'HDATES', 'GDDHARV_PERHARV', 'GDDACCUM_PERHARV', 'HUI_PERHARV', 'SOWING_REASON_PERHARV', 'HARVEST_REASON_PERHARV', 'SWINDOW_STARTS', 'SWINDOW_ENDS', 'GDD20_BASELINE', 'GDD20_SEASON_START', 'GDD20_SEASON_END', 'MAX_TLAI_PERHARV'
17+
hist_fincl3 += 'FROOTC_AT_EMERGENCE_PERHARV', 'FROOTC_AT_ANTHESIS_PERHARV', 'FROOTC_AT_MATURITY_PERHARV', 'FROOTC_AT_HARVEST_PERHARV'
18+
hist_fincl3 += 'LIVECROOTC_AT_EMERGENCE_PERHARV', 'LIVECROOTC_AT_ANTHESIS_PERHARV', 'LIVECROOTC_AT_MATURITY_PERHARV', 'LIVECROOTC_AT_HARVEST_PERHARV'
19+
hist_fincl3 += 'LIVESTEMC_AT_EMERGENCE_PERHARV', 'LIVESTEMC_AT_ANTHESIS_PERHARV', 'LIVESTEMC_AT_MATURITY_PERHARV', 'LIVESTEMC_AT_HARVEST_PERHARV'
20+
hist_fincl3 += 'LEAFC_AT_EMERGENCE_PERHARV', 'LEAFC_AT_ANTHESIS_PERHARV', 'LEAFC_AT_MATURITY_PERHARV', 'LEAFC_AT_HARVEST_PERHARV'
21+
hist_fincl3 += 'REPRC_AT_EMERGENCE_PERHARV', 'REPRC_AT_ANTHESIS_PERHARV', 'REPRC_AT_MATURITY_PERHARV', 'REPRC_AT_HARVEST_PERHARV'
1722
hist_nhtfrq = -24,-8,-24
1823
hist_mfilt = 1,1,1
1924
hist_type1d_pertape(3) = 'PFTS'

doc/ChangeLog

Lines changed: 73 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,79 @@ Pull Requests that document the changes (include PR ids):
103103
===============================================================
104104
===============================================================
105105
Tag name: ctsm5.4.016
106+
Originator(s): samrabin (Sam Rabin, UCAR/TSS)
107+
Date: Fri Feb 6 09:09:56 MST 2026
108+
One-line Summary: Merge b4b-dev to master
109+
110+
Purpose and description of changes
111+
----------------------------------
112+
113+
Merge b4b-dev to master
114+
115+
Significant changes to scientifically-supported configurations
116+
--------------------------------------------------------------
117+
118+
Does this tag change answers significantly for any of the following physics configurations?
119+
(Details of any changes will be given in the "Answer changes" section below.)
120+
121+
[ ] clm6_0
122+
123+
[ ] clm5_0
124+
125+
[ ] ctsm5_0-nwp
126+
127+
[ ] clm4_5
128+
129+
130+
Bugs fixed
131+
----------
132+
133+
List of CTSM issues fixed (include CTSM Issue # and description):
134+
- [ESCOMP/CTSM Issue #3696: CropPhenology: Rename leafout to gddtsoi](https://github.com/ESCOMP/CTSM/issues/3696)
135+
- [ESCOMP/CTSM Issue #3057: error in errsol computation in BalanceCheckMod reports the wrong albedo values](https://github.com/ESCOMP/CTSM/issues/3057)
136+
137+
138+
Notes of particular relevance for users
139+
---------------------------------------
140+
141+
Changes to CTSM's user interface (e.g., new/renamed XML or namelist variables):
142+
- New `suppress_gddmaturity_warning` namelist flag, default false.
143+
144+
145+
Notes of particular relevance for developers:
146+
---------------------------------------------
147+
148+
Changes to tests or testing:
149+
- New Python unit and system tests.
150+
- New Fortran unit tests.
151+
- RXCROPMATURITY_ tests added to expected failure list. Will be resolved soon.
152+
153+
154+
Testing summary:
155+
----------------
156+
157+
python testing (if python code has changed; see instructions in python/README.md; document testing done):
158+
159+
derecho - OK
160+
161+
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
162+
163+
derecho ----- OK
164+
izumi ------- OK
165+
166+
167+
Other details
168+
-------------
169+
170+
Pull Requests that document the changes (include PR ids):
171+
- [ESCOMP/CTSM Pull Request #3713: Factor out new subroutine CropPhase_OnePatch](https://github.com/ESCOMP/CTSM/pull/3713)
172+
- [ESCOMP/CTSM Pull Request #3633: Add history outputs: Crop biomass and LAI per harvest](https://github.com/ESCOMP/CTSM/pull/3633)
173+
- [ESCOMP/CTSM Pull Request #3727: Minor improvements to generate_gdd20_baseline.py](https://github.com/ESCOMP/CTSM/pull/3727)
174+
- [ESCOMP/CTSM Pull Request #3710: Improve radiation balance check](https://github.com/ESCOMP/CTSM/pull/3710)
175+
- [ESCOMP/CTSM Pull Request #3729: generate_gdds: Work on arguments](https://github.com/ESCOMP/CTSM/pull/3729)
176+
- [ESCOMP/CTSM Pull Request #3738: generate_gdds: Get file lists earlier](https://github.com/ESCOMP/CTSM/pull/3738)
177+
- [ESCOMP/CTSM Pull Request #3741: ctsm5.4.016: b4b-dev merge 2026-02-05](https://github.com/ESCOMP/CTSM/pull/3741)
178+
106179
===============================================================
107180
===============================================================
108181
Tag name: ctsm5.4.015

doc/ChangeSum

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Tag Who Date Summary
22
============================================================================================================================
33
ctsm5.4.017 slevis 02/06/2026 Introduce CRUJRA2024b datm option (Greenand snow hole filled)
4-
ctsm5.4.016
4+
ctsm5.4.016 samrabin 02/06/2026 Merge b4b-dev to master
55
ctsm5.4.015 erik 02/03/2026 Update CISM to latest version with answer changes
66
ctsm5.4.014 mvdebols 01/29/2026 Fix for xm2 and revise logic for excess ice melt
77
ctsm5.4.013 erik 01/28/2026 Patch the Greenland snow hole with initial conditions for ne30 and tweak the C14 isotope latitudes

0 commit comments

Comments
 (0)