ReferenceUsedNamesOnlySniff: importing global functions and constants is not necessary in the global namespace

Author: kukulich

SlevomatCodingStandard/Sniffs/Namespaces/ReferenceUsedNamesOnlySniff.php

@@ -213,6 +213,7 @@ public function process(\PHP_CodeSniffer\Files\File $phpcsFile, $openTagPointer)
 			$isFullyQualified = NamespaceHelper::isFullyQualifiedName($name);
 			$isGlobalFallback = !$isFullyQualified
 				&& !NamespaceHelper::hasNamespace($name)
+				&& NamespaceHelper::findCurrentNamespaceName($phpcsFile, $startPointer) !== null
 				&& !array_key_exists(UseStatement::getUniqueId($reference->type, $name), $useStatements);
 			$isGlobalFunctionFallback = $reference->isFunction && $isGlobalFallback;
 			$isGlobalConstantFallback = $reference->isConstant && $isGlobalFallback;

tests/Sniffs/Namespaces/ReferenceUsedNamesOnlySniffTest.php

@@ -847,4 +847,17 @@ public function testSearchingInAnnotations(): void
 		self::assertAllFixedInFile($report);
 	}
 
+	public function testReferencingGlobalTypesInGlobalNamespace(): void
+	{
+		$report = self::checkFile(
+			__DIR__ . '/data/referencingGlobalTypesInGlobalNamespace.php',
+			[
+				'allowFallbackGlobalFunctions' => false,
+				'allowFallbackGlobalConstants' => false,
+			]
+		);
+
+		self::assertNoSniffErrorInFile($report);
+	}
+
 }

tests/Sniffs/Namespaces/data/referencingGlobalTypesInGlobalNamespace.php

@@ -0,0 +1,7 @@
+<?php
+
+PHP_VERSION;
+
+phpversion();
+
+new DateTimeImmutable();