More tests for weird parameters or properties definitions

Author: kukulich

tests/Helpers/FunctionHelperTest.php

@@ -71,6 +71,10 @@ public function dataParametersNames(): array
 				'someParametersWithNullableTypeHints',
 				['$string', '$int', '$bool', '$float', '$callable', '$array', '$object'],
 			],
+			[
+				'parametersWithWeirdDefinition',
+				['$string', '$int', '$bool', '$float', '$callable', '$array', '$object'],
+			],
 		];
 	}
 
@@ -147,6 +151,23 @@ public function dataParametersTypeHints(): array
 					'$array',
 				],
 			],
+			[
+				'parametersWithWeirdDefinition',
+				[
+					'$string' => new ParameterTypeHint('string', false, false),
+					'$int' => null,
+					'$bool' => new ParameterTypeHint('bool', false, true),
+					'$float' => null,
+					'$callable' => new ParameterTypeHint('callable', false, false),
+					'$array' => null,
+					'$object' => new ParameterTypeHint('\FooNamespace\FooClass', false, false),
+				],
+				[
+					'$int',
+					'$float',
+					'$array',
+				],
+			],
 		];
 	}
 
@@ -180,6 +201,18 @@ public function dataParametersNullableTypeHints(): array
 					'$object' => new ParameterTypeHint('\FooNamespace\FooClass', true, false),
 				],
 			],
+			[
+				'parametersWithWeirdDefinition',
+				[
+					'$string' => new ParameterTypeHint('string', true, false),
+					'$int' => new ParameterTypeHint('int', false, false),
+					'$bool' => new ParameterTypeHint('bool', true, true),
+					'$float' => new ParameterTypeHint('float', false, false),
+					'$callable' => new ParameterTypeHint('callable', true, false),
+					'$array' => new ParameterTypeHint('array', false, true),
+					'$object' => new ParameterTypeHint('\FooNamespace\FooClass', true, false),
+				],
+			],
 		];
 	}
 

tests/Helpers/PropertyHelperTest.php

@@ -30,6 +30,10 @@ public function dataIsProperty(): array
 				'$hoo',
 				false,
 			],
+			[
+				'$weirdDefinition',
+				true,
+			],
 		];
 	}
 

tests/Helpers/data/functionParametersNames.php

@@ -24,4 +24,6 @@ public function allParametersWithNullableTypeHints(?string $string, ?int $int =
 
 	abstract public function someParametersWithNullableTypeHints(?string $string, int $int, ?bool $bool = true, float $float, ?callable $callable, array $array = [], ?\FooNamespace\FooClass $object);
 
+	abstract public function parametersWithWeirdDefinition(?string$string,int$int,?bool$bool=true,float$float,?callable$callable,array$array=[],?\FooNamespace\FooClass$object);
+
 }

tests/Helpers/data/functionParametersNullableTypeHints.php

@@ -12,4 +12,6 @@ public function allParametersWithNullableTypeHints(?string $string, ?int $int =
 
 	abstract public function someParametersWithNullableTypeHints(?string $string, int $int, ?bool $bool = true, float $float, ?callable $callable, array $array = [], ?\FooNamespace\FooClass $object);
 
+	abstract public function parametersWithWeirdDefinition(?string$string,int$int,?bool$bool=true,float$float,?callable$callable,array$array=[],?\FooNamespace\FooClass$object);
+
 }

tests/Helpers/data/functionParametersTypeHints.php

@@ -17,4 +17,6 @@ final public function allParametersWithoutTypeHints($string = '', $int, $bool, $
 
 	abstract public function someParametersWithoutTypeHints(string $string, $int, bool $bool = true, $float, callable $callable, $array = [], \FooNamespace\FooClass $object);
 
+	abstract public function parametersWithWeirdDefinition(string$string,$int,bool$bool=true,$float,callable$callable,$array=[],\FooNamespace\FooClass$object);
+
 }

tests/Helpers/data/propertyOrNot.php

@@ -15,4 +15,6 @@ public function __construct($boo)
 		$hoo = $boo;
 	}
 
+	private$weirdDefinition;
+
 }

tests/Sniffs/Classes/UnusedPrivateElementsSniffTest.php

@@ -71,6 +71,19 @@ public function testErrors()
 			UnusedPrivateElementsSniff::CODE_UNUSED_METHOD,
 			'Class ClassWithSomeUnusedProperties contains unused private method unusedMethodReturningReference().'
 		);
+
+		$this->assertSniffError(
+			$resultFile,
+			101,
+			UnusedPrivateElementsSniff::CODE_UNUSED_PROPERTY,
+			'Class ClassWithSomeUnusedProperties contains unused property $unusedPropertyWithWeirdDefinition.'
+		);
+		$this->assertSniffError(
+			$resultFile,
+			103,
+			UnusedPrivateElementsSniff::CODE_WRITE_ONLY_PROPERTY,
+			'Class ClassWithSomeUnusedProperties contains write-only property $unusedWriteOnlyPropertyWithWeirdDefinition.'
+		);
 	}
 
 	public function testOnlyPublicElements()

tests/Sniffs/Classes/data/classWithSomeUnusedElements.php

@@ -98,4 +98,13 @@ private function &unusedMethodReturningReference()
 		return [];
 	}
 
+	private$unusedPropertyWithWeirdDefinition;
+
+	private$unusedWriteOnlyPropertyWithWeirdDefinition;
+
+	public function unusedWriteOnlyPropertyWithWeirdDefinitionMethod()
+	{
+		$this->unusedWriteOnlyPropertyWithWeirdDefinition = null;
+	}
+
 }

tests/Sniffs/TypeHints/NullableTypeForNullDefaultValueSniffTest.php

@@ -18,7 +18,7 @@ public function testErrors()
 			'enabled' => true,
 		]);
 
-		$this->assertSame(11, $report->getErrorCount());
+		$this->assertSame(12, $report->getErrorCount());
 
 		$code = NullableTypeForNullDefaultValueSniff::CODE_NULLABILITY_SYMBOL_REQUIRED;
 		$this->assertSniffError($report, 3, $code);
@@ -32,6 +32,7 @@ public function testErrors()
 		$this->assertSniffError($report, 47, $code);
 		$this->assertSniffError($report, 52, $code);
 		$this->assertSniffError($report, 57, $code);
+		$this->assertSniffError($report, 62, $code);
 	}
 
 	public function testFixable()

tests/Sniffs/TypeHints/data/nullableTypeForNullDefaultValueErrors.php

@@ -59,4 +59,9 @@ public function reference(float & $ref = null)
 
 	}
 
+	public function weirdDefinition(float&$ref=null)
+	{
+
+	}
+
 }