Skip to content

Commit 080f592

Browse files
committed
SlevomatCodingStandard.Namespaces.FullyQualifiedClassNameInAnnotation: Fixed false positive with self::CONSTANT
1 parent 71dddfe commit 080f592

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

SlevomatCodingStandard/Sniffs/Namespaces/FullyQualifiedClassNameInAnnotationSniff.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ public function process(File $phpcsFile, $docCommentOpenPointer): void
109109
? $constantFetchNode->className
110110
: $constantFetchNode->name;
111111

112+
if ($typeHint === 'self') {
113+
continue;
114+
}
115+
112116
$fullyQualifiedTypeHint = $isClassConstant
113117
? NamespaceHelper::resolveClassName(
114118
$phpcsFile,

tests/Sniffs/Namespaces/data/fullyQualifiedClassNameInAnnotationNoErrors.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ public function withNever()
178178
}
179179

180180
/**
181-
* @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC)
181+
* @method sortBy(callable $path, int $order = \SORT_DESC, int $sort = \SORT_NUMERIC, int $flags = self::FLAG)
182182
*/
183183
class ConstantExpression
184184
{

0 commit comments

Comments
 (0)