Autodisable PHP 7.1 only sniffs

Author: VasekPurchart

SlevomatCodingStandard/Sniffs/Classes/ClassConstantVisibilitySniff.php

@@ -10,11 +10,22 @@ class ClassConstantVisibilitySniff implements \PHP_CodeSniffer_Sniff
 
 	const CODE_MISSING_CONSTANT_VISIBILITY = 'MissingConstantVisibility';
 
+	/**
+	 * Automatically disables the sniff on unusable version, to be removed when only PHP 7.1+ is supported
+	 *
+	 * @var bool
+	 */
+	public $enabled = PHP_VERSION_ID >= 70100;
+
 	/**
 	 * @return int[]
 	 */
 	public function register(): array
 	{
+		if (!$this->enabled) {
+			return [];
+		}
+
 		return [
 			T_CONST,
 		];

SlevomatCodingStandard/Sniffs/TypeHints/NullableTypeForNullDefaultValueSniff.php

@@ -9,11 +9,22 @@ class NullableTypeForNullDefaultValueSniff implements \PHP_CodeSniffer_Sniff
 
 	const CODE_NULLABILITY_SYMBOL_REQUIRED = 'NullabilitySymbolRequired';
 
+	/**
+	 * Automatically disables the sniff on unusable version, to be removed when only PHP 7.1+ is supported
+	 *
+	 * @var bool
+	 */
+	public $enabled = PHP_VERSION_ID >= 70100;
+
 	/**
 	 * @return int[]
 	 */
 	public function register(): array
 	{
+		if (!$this->enabled) {
+			return [];
+		}
+
 		return [
 			T_FUNCTION,
 			T_CLOSURE,

tests/Sniffs/Classes/ClassConstantVisibilitySniffTest.php

@@ -7,7 +7,9 @@ class ClassConstantVisibilitySniffTest extends \SlevomatCodingStandard\Sniffs\Te
 
 	public function testErrors()
 	{
-		$report = $this->checkFile(__DIR__ . '/data/classWithConstants.php');
+		$report = $this->checkFile(__DIR__ . '/data/classWithConstants.php', [
+			'enabled' => true,
+		]);
 
 		$this->assertSame(1, $report->getErrorCount());
 
@@ -25,13 +27,25 @@ public function testErrors()
 
 	public function testNoClassConstants()
 	{
-		$report = $this->checkFile(__DIR__ . '/data/noClassConstants.php');
+		$report = $this->checkFile(__DIR__ . '/data/noClassConstants.php', [
+			'enabled' => true,
+		]);
 		$this->assertNoSniffErrorInFile($report);
 	}
 
 	public function testNoClassConstantsWithNamespace()
 	{
-		$report = $this->checkFile(__DIR__ . '/data/noClassConstantsWithNamespace.php');
+		$report = $this->checkFile(__DIR__ . '/data/noClassConstantsWithNamespace.php', [
+			'enabled' => true,
+		]);
+		$this->assertNoSniffErrorInFile($report);
+	}
+
+	public function testDisabledSniff()
+	{
+		$report = $this->checkFile(__DIR__ . '/data/classWithConstants.php', [
+			'enabled' => false,
+		]);
 		$this->assertNoSniffErrorInFile($report);
 	}
 

tests/Sniffs/TypeHints/NullableTypeForNullDefaultValueSniffTest.php

@@ -7,12 +7,16 @@ class NullableTypeForNullDefaultValueSniffTest extends \SlevomatCodingStandard\S
 
 	public function testNoErrors()
 	{
-		$this->assertNoSniffErrorInFile($this->checkFile(__DIR__ . '/data/nullableTypeForNullDefaultValueNoErrors.php'));
+		$this->assertNoSniffErrorInFile($this->checkFile(__DIR__ . '/data/nullableTypeForNullDefaultValueNoErrors.php', [
+			'enabled' => true,
+		]));
 	}
 
 	public function testErrors()
 	{
-		$report = $this->checkFile(__DIR__ . '/data/nullableTypeForNullDefaultValueErrors.php');
+		$report = $this->checkFile(__DIR__ . '/data/nullableTypeForNullDefaultValueErrors.php', [
+			'enabled' => true,
+		]);
 
 		$this->assertSame(11, $report->getErrorCount());
 
@@ -33,8 +37,18 @@ public function testErrors()
 	public function testFixable()
 	{
 		$codes = [NullableTypeForNullDefaultValueSniff::CODE_NULLABILITY_SYMBOL_REQUIRED];
-		$report = $this->checkFile(__DIR__ . '/data/fixableNullableTypeForNullDefaultValue.php', [], $codes);
+		$report = $this->checkFile(__DIR__ . '/data/fixableNullableTypeForNullDefaultValue.php', [
+			'enabled' => true,
+		], $codes);
 		$this->assertAllFixedInFile($report);
 	}
 
+	public function testDisabledSniff()
+	{
+		$report = $this->checkFile(__DIR__ . '/data/nullableTypeForNullDefaultValueErrors.php', [
+			'enabled' => false,
+		]);
+		$this->assertNoSniffErrorInFile($report);
+	}
+
 }