Don't try to find references in double quoted string - it's difficult to parse it with PHPCS

This reverts commit add9082.
This reverts commit db24381.

Author: kukulich

SlevomatCodingStandard/Helpers/ReferencedNameHelper.php

@@ -9,7 +9,6 @@
 use function array_values;
 use function count;
 use function in_array;
-use function preg_match;
 use const T_ANON_CLASS;
 use const T_ARRAY;
 use const T_AS;
@@ -24,7 +23,6 @@
 use const T_CONST;
 use const T_DECLARE;
 use const T_DOUBLE_COLON;
-use const T_DOUBLE_QUOTED_STRING;
 use const T_ELLIPSIS;
 use const T_EXTENDS;
 use const T_FUNCTION;
@@ -129,7 +127,7 @@ private static function createAllReferencedNames(File $phpcsFile, int $openTagPo
 		$referencedNames = [];
 
 		$beginSearchAtPointer = $openTagPointer + 1;
-		$nameTokenCodes = array_merge([T_DOUBLE_QUOTED_STRING], TokenHelper::getNameTokenCodes());
+		$nameTokenCodes = TokenHelper::getNameTokenCodes();
 		$tokens = $phpcsFile->getTokens();
 
 		while (true) {
@@ -138,18 +136,6 @@ private static function createAllReferencedNames(File $phpcsFile, int $openTagPo
 				break;
 			}
 
-			if ($tokens[$nameStartPointer]['code'] === T_DOUBLE_QUOTED_STRING) {
-				if (
-					preg_match('~(\$)?(' . TypeHelper::REGEXP . ')::~', $tokens[$nameStartPointer]['content'], $matches) === 1
-					&& $matches[1] === ''
-				) {
-					$referencedNames[] = new ReferencedName($matches[2], $nameStartPointer, $nameStartPointer, ReferencedName::TYPE_CLASS);
-				}
-
-				$beginSearchAtPointer = $nameStartPointer + 1;
-				continue;
-			}
-
 			// Attributes are parsed in specific method
 			$attributeStartPointerBefore = TokenHelper::findPrevious($phpcsFile, T_ATTRIBUTE, $nameStartPointer - 1, $beginSearchAtPointer);
 			if ($attributeStartPointerBefore !== null) {

SlevomatCodingStandard/Helpers/TypeHelper.php

@@ -12,8 +12,6 @@
 class TypeHelper
 {
 
-	public const REGEXP = '\\\\?([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)(\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)*';
-
 	/**
 	 * Validates type name according to the allowed characters in type names + namespaces
 	 *
@@ -24,7 +22,11 @@ class TypeHelper
 	public static function isTypeName(string $typeName): bool
 	{
 		$matches = [];
-		$result = preg_match('~^' . self::REGEXP . '$~', $typeName, $matches);
+		$result = preg_match(
+			'~^\\\\?([a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)(\\\\[a-zA-Z_\x7f-\xff][a-zA-Z0-9_\x7f-\xff]*)*$~',
+			$typeName,
+			$matches
+		);
 		if ($result === false) {
 			// @codeCoverageIgnoreStart
 			throw new Exception('PREG error ' . preg_last_error());

tests/Helpers/ReferencedNameHelperTest.php

@@ -67,7 +67,6 @@ public function testGetAllReferencedNames(): void
 			['STR_PAD_RIGHT', false, true],
 			['EnumType', false, false],
 			['UrlGeneratorInterface', false, false],
-			['ClassInString', false, false],
 		];
 
 		$names = ReferencedNameHelper::getAllReferencedNames($phpcsFile, 0);

tests/Helpers/data/lotsOfReferencedNames.php

@@ -176,16 +176,3 @@ public function generateRoute($router): string
         ], referenceType: UrlGeneratorInterface::RELATIVE_PATH);
     }
 }
-
-class InString
-{
-
-	public function doSomething()
-	{
-		$a = "String interpolation:{$this->getParameter(ClassInString::PARAM_NAME)}";
-		$b = "String interpolation:{$this->getParameter($noClassInString::PARAM_NAME)}";
-
-		return $a . $b;
-	}
-
-}

tests/Sniffs/Namespaces/UnusedUsesSniffTest.php

@@ -66,9 +66,6 @@ public function testUnusedUse(): void
 
 		// Used class with static variable
 		self::assertNoSniffError($report, 29);
-
-		// Used in string
-		self::assertNoSniffError($report, 30);
 	}
 
 	public function testUnusedUseWithMultipleNamespaces(): void

tests/Sniffs/Namespaces/data/unusedUses.php

@@ -27,7 +27,6 @@
 use EnumClass;
 use ReferenceClass;
 use ClassWithStaticVariable;
-use ClassInString;
 
 class TestClass implements FirstInterface, SecondInterface
 {
@@ -57,8 +56,6 @@ enum_type: EnumClass::VALUE(),
 			reference_type: ReferenceClass::SOME_CONSTANT
 		);
 
-		$string = "String interpolation:{$this->getParameter(ClassInString::PARAM_NAME)}";
-
 		return new NewObject();
 	}