TypeHintDeclarationSniff: Invalid annotations should be ignored

kukulich · kukulich · commit 165c96a374c4 · 2019-02-12T21:53:21.000+01:00
diff --git a/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php b/SlevomatCodingStandard/Sniffs/TypeHints/TypeHintDeclarationSniff.php
@@ -736,6 +736,10 @@ private function checkPropertyTypeHint(File $phpcsFile, int $propertyPointer): v
 			return;
 		}
 
+		if ($varAnnotations[0]->isInvalid()) {
+			return;
+		}
+
 		$propertyTypeNode = $varAnnotations[0]->getType();
 
 		if (
diff --git a/tests/Sniffs/TypeHints/data/typeHintDeclarationNoErrors.php b/tests/Sniffs/TypeHints/data/typeHintDeclarationNoErrors.php
@@ -692,6 +692,11 @@ public function returnsArrayOrString()
 		return [];
 	}
 
+	/**
+	 * @var string|
+	 */
+	private $invalidAnnotation;
+
 }
 
 class IntersectionAndGeneric

Original file line number	Diff line number	Diff line change
`@@ -736,6 +736,10 @@ private function checkPropertyTypeHint(File $phpcsFile, int $propertyPointer): v`
`736`	`736`	`return;`
`737`	`737`	`}`
`738`	`738`
	`739`	`+ if ($varAnnotations[0]->isInvalid()) {`
	`740`	`+ return;`
	`741`	`+ }`
	`742`	`+`
`739`	`743`	`$propertyTypeNode = $varAnnotations[0]->getType();`
`740`	`744`
`741`	`745`	`if (`
Original file line number	Diff line number	Diff line change
`@@ -692,6 +692,11 @@ public function returnsArrayOrString()`
`692`	`692`	`return [];`
`693`	`693`	`}`
`694`	`694`
	`695`	`+ /**`
	`696`	`+ * @var string\|`
	`697`	`+ */`
	`698`	`+ private $invalidAnnotation;`
	`699`	`+`
`695`	`700`	`}`
`696`	`701`
`697`	`702`	`class IntersectionAndGeneric`