Fixed YodaComparisonSniff for negative or plus-prepended expressions

Author: ondrejmirtes

SlevomatCodingStandard/Sniffs/ControlStructures/YodaComparisonSniff.php

@@ -222,7 +222,7 @@ private function getDynamismForTokens(array $sideTokens)
 	{
 		$dynamism = $this->getTokenDynamism();
 		$sideTokens = array_values(array_filter($sideTokens, function (array $token) {
-			return !in_array($token['code'], [T_WHITESPACE, T_COMMENT, T_DOC_COMMENT, T_NS_SEPARATOR], true);
+			return !in_array($token['code'], [T_WHITESPACE, T_COMMENT, T_DOC_COMMENT, T_NS_SEPARATOR, T_PLUS, T_MINUS], true);
 		}));
 
 		if (count($sideTokens) > 0) {

tests/Sniffs/ControlStructures/YodaComparisonSniffTest.php

@@ -14,7 +14,7 @@ public function testCorrectFile()
 	public function dataIncorrectFile()
 	{
 		$lineNumbers = [];
-		foreach (range(3, 20) as $lineNumber) {
+		foreach (range(3, 22) as $lineNumber) {
 			$lineNumbers[$lineNumber] = [$lineNumber];
 		}
 

tests/Sniffs/ControlStructures/data/allYodaComparisons.php

@@ -14,6 +14,8 @@
 Foo::BAR === $foo;
 Foo::BAR === $foo + 2;
 Foo::BAR === $this->foo();
+-1 === $foo;
++1 === $foo;
 (BAR === foo() || (
 	['test'] === Foo::BAR
 )) ? 123.0 === Foo::BAR

tests/Sniffs/ControlStructures/data/noYodaComparisons.php

@@ -16,6 +16,8 @@
 $foo === Foo::BAR;
 $foo + 2 === Foo::BAR;
 $this->foo() === Foo::BAR;
+$foo === -1;
+$foo === +1;
 count($cartItem->getReservations()) !== $neededReservationsAmount;
 $optionalPartOpeningBracePosition !== strlen($part) - 1;
 $optionalPartOpeningBracePosition !== \Nette\Utils\Strings::length($part) - 1;